fixed wgs84 conversion equation #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
calculateNewPos()method ofUtilFunctionsclass.The constant DEGREE_IN_M should be adjusted by$$\times \cos(\phi)$$ — since as latitude ($$\phi$$ ) increases, the longitudinal distance per degree decreases proportionally to cos(φ).
In the original code:
double newLongitude=initialLocation.longitude+(pdrMoved[0]/(DEGREE_IN_M))*Math.cos(Math.toRadians(initialLocation.latitude));the brackets were misplaced, applying the correction as: DEGREE_IN_M$$\div \cos(\phi)$$ .
This is incorrect and results in overcompensation at higher latitudes, causing a substantial amount of translation error.
This pull request corrects the equation by properly applying the cosine adjustment in the denominator. The updated code ensures the correction factor is applied as intended.