-
Notifications
You must be signed in to change notification settings - Fork 9
Adding new method: DRVI #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I flagged some redundant preprocessing code in the script that shouldn't be part of this module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Could you also add a new entry to the Changelog?
Co-authored-by: Michaela Müller <[email protected]>
Co-authored-by: Michaela Müller <[email protected]>
@mumichae Thank you for the review! Changelog is added :) |
Describe your changes
This is a PR to add a new method, DRVI into the batch integration tasks.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!