A570218846721951 health check#26
Open
Scandie wants to merge 8 commits intoopenprocurement:eauctions-sandboxfrom
Open
A570218846721951 health check#26Scandie wants to merge 8 commits intoopenprocurement:eauctions-sandboxfrom
Scandie wants to merge 8 commits intoopenprocurement:eauctions-sandboxfrom
Conversation
* Remove specified version of setuptools from travis.yml
yarsanich
reviewed
Mar 5, 2018
Collaborator
yarsanich
left a comment
yarsanich
left a comment
There was a problem hiding this comment.
Я б зробив init_services методом воркера і поділив його ще не три метода, або утиліти на чек кожного сервісу.
| auction_data=auction_data, | ||
| lot_id=args.lot) | ||
| if args.cmd == 'check': | ||
| exit() |
| logging.addLevelName(25, 'CHECK') | ||
|
|
||
|
|
||
| def check(self, msg, exc=None, *args, **kwargs): |
| return pause | ||
|
|
||
|
|
||
| def init_services(auction): |
Collaborator
There was a problem hiding this comment.
Можливо варто щоб init_sevices був методом самого воркера ?
| auction.session_ds = RequestsSession() | ||
| LOGGER.check('{} - {}'.format("API", result[0]), result[1]) | ||
|
|
||
| # Checking CouchDB availability |
Collaborator
There was a problem hiding this comment.
Тобі не виглядає, що ці три коментарі, на ініт кожного сервіса, можна винести в окремий метод, може так буде краще виглядати і зрозуміліше що відбувається ?
Collaborator
There was a problem hiding this comment.
Протестувати окремо можна буде.
Collaborator
Author
There was a problem hiding this comment.
Думав над таким варіантом, ок, повиношу.
* Split init_services to separate init methods for each service * Replace exit() call wit sys.exit()
* Remove unused imports
* Add tests for InitializeServiceMixin
yarsanich
reviewed
Mar 7, 2018
| logging.addLevelName(25, 'CHECK') | ||
|
|
||
|
|
||
| def check(self, msg, exc=None, *args, **kwargs): |
Collaborator
There was a problem hiding this comment.
А її хіба не можна імпортувати ?
yarsanich
reviewed
Mar 7, 2018
| from urlparse import urljoin | ||
|
|
||
| import iso8601 | ||
| from couchdb import Server, Session |
* Reorganize import statements
Scandie
force-pushed
the
a570218846721951_health_check
branch
from
cd22b46 to
7dfb9e5
Compare
Collaborator
Author
|
depends on openprocurement/openprocurement.auction#86 |
yarsanich
approved these changes
Mar 12, 2018
Scandie
force-pushed
the
a570218846721951_health_check
branch
from
6d20e3e to
95148c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.