a430282460355758_fix_chronograph_tests#11
a430282460355758_fix_chronograph_tests#11vladkhard wants to merge 1 commit intoopenprocurement:a258001251842882_refactoringfrom
Conversation
|
Changes Unknown when pulling d879cae on vladkhard:a430282460355758 into ** on openprocurement:a258001251842882_refactoring**. |
|
|
||
| [sources] | ||
| openprocurement.api = git https://github.com/openprocurement/openprocurement.api.git branch=a258001251842882_refactoring | ||
| openprocurement.api = git https://github.com/openprocurement/openprocurement.api.git |
There was a problem hiding this comment.
Проблема з тестами була пов'язана з ImportError: cannot import name VERSION
https://travis-ci.org/openprocurement/openprocurement.chronograph/builds/274527401
Переключення на master гілку openprocurement.api це не фікс помилки. master гілка містить sandbox версію коду, який не попаде в production.
Правильний фікс - імпортувати змінну з того місця, де вона визначена.
vladkhard
force-pushed
the
a430282460355758
branch
from
d879cae to
43cb2ed
Compare
|
Changes Unknown when pulling 43cb2ed on vladkhard:a430282460355758 into ** on openprocurement:a258001251842882_refactoring**. |
| from requests.structures import CaseInsensitiveDict | ||
| from requests.utils import get_encoding_from_headers | ||
| from openprocurement.chronograph.scheduler import SESSION | ||
| from openprocurement.api.utils import VERSION |
There was a problem hiding this comment.
Для зворотньої сумісності можна помістити цей import в try/except ImportError
| cryptography = 1.0.2 | ||
| idna = 2.0 | ||
| pyOpenSSL = 0.15.1 | ||
| cffi = 1.9.1 |
There was a problem hiding this comment.
Краще взяти версії з op.buildout
vladkhard
force-pushed
the
a430282460355758
branch
2 times, most recently
from
4b6c00b to
84216b3
Compare
|
Changes Unknown when pulling 84216b3 on vladkhard:a430282460355758 into ** on openprocurement:a258001251842882_refactoring**. |
|
Changes Unknown when pulling 84216b3 on vladkhard:a430282460355758 into ** on openprocurement:a258001251842882_refactoring**. |
vladkhard
force-pushed
the
a430282460355758
branch
from
84216b3 to
84d3979
Compare
|
Changes Unknown when pulling 84216b3 on vladkhard:a430282460355758 into ** on openprocurement:a258001251842882_refactoring**. |
| try: | ||
| from openprocurement.api.utils import VERSION | ||
| except ImportError: | ||
| from openprocurement.api.constants import VERSION |
There was a problem hiding this comment.
Треба їх поміняти місцями. Ми ж в майбутнє дивимся.
vladkhard
force-pushed
the
a430282460355758
branch
from
84d3979 to
f7fa4b2
Compare
vladkhard
force-pushed
the
a430282460355758
branch
from
f7fa4b2 to
e7b6ac1
Compare
|
Changes Unknown when pulling e7b6ac1 on vladkhard:a430282460355758 into ** on openprocurement:a258001251842882_refactoring**. |
|
Changes Unknown when pulling e7b6ac1 on vladkhard:a430282460355758 into ** on openprocurement:a258001251842882_refactoring**. |
|
Changes Unknown when pulling e7b6ac1 on vladkhard:a430282460355758 into ** on openprocurement:a258001251842882_refactoring**. |
4 participants
змінив гілку openprocurement.api з a258001251842882_refactoring на master
This change is