-
-
Notifications
You must be signed in to change notification settings - Fork 3
Fix/refactorings #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Fix/refactorings #69
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #69 +/- ##
==========================================
- Coverage 96.37% 93.84% -2.53%
==========================================
Files 4 4
Lines 220 227 +7
Branches 30 30
==========================================
+ Hits 212 213 +1
- Misses 5 11 +6
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AHReccese Can you add tests to increase the coverage? This looks a little bit suspicious to me and I don't want to merge it without tests.
I need @sepandhaghighi to also review this PR. I can't review it on my own.
After this PR I we're good for a release. We haven't released for a long time.
|
@AHReccese a friendly reminder on my comment for this. |
|
Thank you, Sadra. Adding tests to cover the related corner cases is a bit challenging, but I’ll think it through and we can also discuss it in our meeting. I’ll explain the changes to Sepand, and together we can find a way forward. |
|
Feedback from Sepand:
|
Dear @AHReccese, this is a friendly reminder for this PR. |
…ceptions and improve clarity in comments. Ensure `_play_process` is set to `None` after termination attempts.
|
@sepandhaghighi @sadrasabouri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I would like to have @sepandhaghighi 's review on this before merge.
Reference Issues/PRs
Previously when I was adding
WinMMengine, I saw some areas in the implementation which needed some minor improvement and in this PR I'm applying them.What does this implement/fix? Explain your changes.
Any other comments?
Local tests on OSs