-
Notifications
You must be signed in to change notification settings - Fork 2k
[Tiered Caching] Remove PLUGGABLE_CACHE feature flag #17344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tiered Caching] Remove PLUGGABLE_CACHE feature flag #17344
Conversation
Signed-off-by: Peter Alfonsi <[email protected]>
f8ebfd4
to
cb6dea2
Compare
Signed-off-by: Peter Alfonsi <[email protected]>
Flaky test: #17291 |
Signed-off-by: Peter Alfonsi <[email protected]>
❕ Gradle check result for 8a559cb: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17344 +/- ##
============================================
+ Coverage 71.54% 72.43% +0.89%
- Complexity 64883 65749 +866
============================================
Files 5311 5311
Lines 304903 304898 -5
Branches 44215 44213 -2
============================================
+ Hits 218133 220865 +2732
+ Misses 68896 66016 -2880
- Partials 17874 18017 +143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Peter Alfonsi <[email protected]>
❌ Gradle check result for de67767: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test: #17540 |
Signed-off-by: Peter Alfonsi <[email protected]>
❕ Gradle check result for 6092df8: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@andrross Could you take another look at this one when you get a chance? |
…ect#17344) * Remove PLUGGABLE_CACHE feature flag Signed-off-by: Peter Alfonsi <[email protected]> * changelog Signed-off-by: Peter Alfonsi <[email protected]> * move changelog entry Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * fix IT init failure Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]>
…ect#17344) * Remove PLUGGABLE_CACHE feature flag Signed-off-by: Peter Alfonsi <[email protected]> * changelog Signed-off-by: Peter Alfonsi <[email protected]> * move changelog entry Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * fix IT init failure Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]>
* Remove PLUGGABLE_CACHE feature flag * changelog * move changelog entry * rerun gradle * rerun gradle * fix IT init failure * rerun gradle * rerun gradle * rerun gradle * rerun gradle * rerun gradle --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]>
…ect#17344) * Remove PLUGGABLE_CACHE feature flag Signed-off-by: Peter Alfonsi <[email protected]> * changelog Signed-off-by: Peter Alfonsi <[email protected]> * move changelog entry Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * fix IT init failure Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]>
Description
As tiered caching will no longer be experimental in 3.0, removes its feature flag. Now users can always specify a store name via setting, and cache implementations will always track their own stats as exposed in
GET _nodes/stats/caches/...
.Modifies some UTs to account for this. Manually tested with debugger that the TSC can be used in the IRC via setting with the new changes. Also manually checked the response in
GET _nodes/stats/caches/request_cache
is populated even for the default cache.Related Issues
Resolves #17343
Sub-issue of #17303
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.