Skip to content

[Tiered Caching] Remove PLUGGABLE_CACHE feature flag #17344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 7, 2025

Conversation

peteralfonsi
Copy link
Contributor

Description

As tiered caching will no longer be experimental in 3.0, removes its feature flag. Now users can always specify a store name via setting, and cache implementations will always track their own stats as exposed in GET _nodes/stats/caches/....

Modifies some UTs to account for this. Manually tested with debugger that the TSC can be used in the IRC via setting with the new changes. Also manually checked the response in GET _nodes/stats/caches/request_cache is populated even for the default cache.

Related Issues

Resolves #17343
Sub-issue of #17303

Check List

  • Functionality includes testing.
  • [N/A] API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peteralfonsi peteralfonsi force-pushed the remove-tc-feature-flag branch from f8ebfd4 to cb6dea2 Compare February 12, 2025 22:35
Signed-off-by: Peter Alfonsi <[email protected]>
@peteralfonsi
Copy link
Contributor Author

Flaky test: #17291

Signed-off-by: Peter Alfonsi <[email protected]>
Copy link
Contributor

❕ Gradle check result for 8a559cb: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.43%. Comparing base (7388205) to head (6092df8).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../opensearch/common/cache/service/CacheService.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17344      +/-   ##
============================================
+ Coverage     71.54%   72.43%   +0.89%     
- Complexity    64883    65749     +866     
============================================
  Files          5311     5311              
  Lines        304903   304898       -5     
  Branches      44215    44213       -2     
============================================
+ Hits         218133   220865    +2732     
+ Misses        68896    66016    -2880     
- Partials      17874    18017     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Mar 6, 2025

❌ Gradle check result for de67767: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peteralfonsi
Copy link
Contributor Author

Flaky test: #17540

Signed-off-by: Peter Alfonsi <[email protected]>
Copy link
Contributor

github-actions bot commented Mar 6, 2025

❕ Gradle check result for 6092df8: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@peteralfonsi
Copy link
Contributor Author

@andrross Could you take another look at this one when you get a chance?

@github-project-automation github-project-automation bot moved this to 👀 In review in Storage Project Board Mar 7, 2025
@andrross andrross merged commit 105aeb5 into opensearch-project:main Mar 7, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Storage Project Board Mar 7, 2025
peteralfonsi added a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 10, 2025
…ect#17344)

* Remove PLUGGABLE_CACHE feature flag

Signed-off-by: Peter Alfonsi <[email protected]>

* changelog

Signed-off-by: Peter Alfonsi <[email protected]>

* move changelog entry

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* fix IT init failure

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

---------

Signed-off-by: Peter Alfonsi <[email protected]>
Signed-off-by: Peter Alfonsi <[email protected]>
Co-authored-by: Peter Alfonsi <[email protected]>
peteralfonsi added a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 10, 2025
…ect#17344)

* Remove PLUGGABLE_CACHE feature flag

Signed-off-by: Peter Alfonsi <[email protected]>

* changelog

Signed-off-by: Peter Alfonsi <[email protected]>

* move changelog entry

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* fix IT init failure

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

---------

Signed-off-by: Peter Alfonsi <[email protected]>
Signed-off-by: Peter Alfonsi <[email protected]>
Co-authored-by: Peter Alfonsi <[email protected]>
dbwiddis pushed a commit that referenced this pull request Mar 11, 2025
* Remove PLUGGABLE_CACHE feature flag



* changelog



* move changelog entry



* rerun gradle



* rerun gradle



* fix IT init failure



* rerun gradle



* rerun gradle



* rerun gradle



* rerun gradle



* rerun gradle



---------

Signed-off-by: Peter Alfonsi <[email protected]>
Signed-off-by: Peter Alfonsi <[email protected]>
Co-authored-by: Peter Alfonsi <[email protected]>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Mar 18, 2025
…ect#17344)

* Remove PLUGGABLE_CACHE feature flag

Signed-off-by: Peter Alfonsi <[email protected]>

* changelog

Signed-off-by: Peter Alfonsi <[email protected]>

* move changelog entry

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* fix IT init failure

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

* rerun gradle

Signed-off-by: Peter Alfonsi <[email protected]>

---------

Signed-off-by: Peter Alfonsi <[email protected]>
Signed-off-by: Peter Alfonsi <[email protected]>
Co-authored-by: Peter Alfonsi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Performance
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Feature Request] [Tiered Caching] Remove feature flag for tiered caching
2 participants