Skip to content

fix simultaneously creating a snapshot and updating the repository can potentially trigger an infinite loop #17532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix simultaneously creating a snapshot and updating the repository can potentially trigger an infinite loop #17532

merged 1 commit into from
Apr 22, 2025

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Mar 6, 2025 •
edited
Loading

Description

Related Issues

Resolves #17531

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kkewwei kkewwei force-pushed the fix_loop_in_updateRep branch from 3185a72 to 2a17f65 Compare March 6, 2025 10:47
@github-actions github-actions bot added bug Something isn't working Storage:Snapshots labels Mar 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

❌ Gradle check result for 2a17f65: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the fix_loop_in_updateRep branch from 2a17f65 to 0a9da2d Compare March 6, 2025 16:05
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Storage Project Board Apr 17, 2025
@kkewwei kkewwei reopened this Apr 17, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in Storage Project Board Apr 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6ebee6d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Apr 17, 2025

❌ Gradle check result for 6ebee6d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock #14289
DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode #15806
SimpleSearchIT.testSimpleTerminateAfterTrackTotalHitsUpToSize #16851

@kkewwei
Copy link
Contributor Author

kkewwei commented Apr 17, 2025 •
edited
Loading

@andrross @ashking94 I'm very sorry to mention you again. Could someone help continue to review or merge the PR? There are too many flaky tests and Gradle check always fails.

Your help is greatly appreciated. I want to continue #17488, but was blocked by this PR.

This was referenced Apr 17, 2025
Open
Open
@andrross
Copy link
Member

@andrross @ashking94 I'm very sorry to mention you again. Could someone help continue to review or merge the PR? There are too many flaky tests and Gradle check always fails.

Your help is greatly appreciated. I want to continue #17488, but was blocked by this PR.

Thanks for sticking with this @kkewwei. A lot of us are busy with the 3.0 release and as you've noted flaky tests are a major problem at the moment.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6ebee6d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-project-automation github-project-automation bot moved this from 🏗 In progress to 👀 In review in Storage Project Board Apr 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6ebee6d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6ebee6d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross force-pushed the fix_loop_in_updateRep branch from 6ebee6d to 7415b92 Compare April 21, 2025 23:10
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 7415b92: SUCCESS

This was referenced Apr 22, 2025
Open
Open
@andrross andrross merged commit f122c46 into opensearch-project:main Apr 22, 2025
30 of 31 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Storage Project Board Apr 22, 2025
This was referenced Apr 22, 2025
Open
Open
x-INFiN1TY-x pushed a commit to x-INFiN1TY-x/OpenSearch_Local that referenced this pull request Apr 24, 2025
@kkewwei @tqranjan
Fix loop when updating reposity and creating snapshot (opensearch-pro…
ae2f098 
…ject#17532)

Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Signed-off-by: Tanishq Ranjan <[email protected]>
This was referenced Apr 24, 2025
Closed
Open
Open
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
@kkewwei
Fix loop when updating reposity and creating snapshot (opensearch-pro…
6c6a80d 
…ject#17532)

Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
@kkewwei
Fix loop when updating reposity and creating snapshot (opensearch-pro…
3398d88 
…ject#17532)

Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashking94 ashking94 ashking94 left review comments

@andrross andrross andrross approved these changes

@bugmakerrrrrr bugmakerrrrrr bugmakerrrrrr approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@cwperks cwperks Awaiting requested review from cwperks

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis

@gbbafna gbbafna Awaiting requested review from gbbafna

@jainankitk jainankitk Awaiting requested review from jainankitk

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal

@linuxpi linuxpi Awaiting requested review from linuxpi

@mch2 mch2 Awaiting requested review from mch2

@msfroh msfroh Awaiting requested review from msfroh

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19

@reta reta Awaiting requested review from reta

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@sachinpkale sachinpkale Awaiting requested review from sachinpkale

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli

@shwetathareja shwetathareja Awaiting requested review from shwetathareja

@sohami sohami Awaiting requested review from sohami

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees
No one assigned
Labels
bug Something isn't working Storage:Snapshots
Projects
Storage Project Board
Status: ✅ Done
Milestone
No milestone
4 participants
@kkewwei @andrross @ashking94 @bugmakerrrrrr