-
Notifications
You must be signed in to change notification settings - Fork 580
Update documentation for the configurability of the semantic field. #10321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Bo Zhang <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
@bzhangam Is this PR ready for doc review or do you want your team to review first? |
@kolchfa-aws Since this is just to update the existing doc I think it's ok for you to start the review. I'll ask my team to review it at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@bzhangam I see we have a tech review, so I'll review shortly. We require all tech reviews to be completed before we start doc review: this way the doc review happens once instead of multiple times. That said, a tech review is optional if you're the feature developer. Thanks! |
Signed-off-by: Fanit Kolchina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bzhangam! Doc review complete: moving on to editorial review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial review
Signed-off-by: Nathan Bower <[email protected]>
Description
Update documentation for the configurability of the semantic field.
Issues Resolved
Closes #10320
Version
List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.
3.2
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.