Prepare for migration from /docs/latest to /latest #10324
Conversation
Signed-off-by: Fanit Kolchina <[email protected]>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Fanit Kolchina <[email protected]>
| @@ -191,10 +191,10 @@ class VersionSelector extends HTMLElement { | |||
|
|
|||
| frag.querySelector('#selected').textContent = `${PREFIX}${this.getAttribute('selected')}`; | |||
|
|
|||
| const pathName = location.pathname.replace(/\/docs(\/((latest|\d+\.\d+)\/?)?)?/, ''); | |||
| const pathName = location.pathname.replace(/\/(docs)?(\/((latest|\d+\.\d+)\/?)?)?/, ''); | |||
There was a problem hiding this comment.
@peterzhuamazon Could you verify that this change is correct for the version selector to work for both old and new versions? Should we do it like this?
There was a problem hiding this comment.
I think we can keep this for now, with or without docs it will strip, my only concern is it will strip if there is another /<number.number>/ in other part of the url string which will get stripped as well.
Signed-off-by: Fanit Kolchina <[email protected]>
|
Keep this until the next Thursday for deployment. |
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
AMoo-Miki,
natebower,
dlvenable,
epugh and
sumobrian
as code owners
* Prepare for migration from /docs/latest to /latest Signed-off-by: Fanit Kolchina <[email protected]> * Fix hardcoded link Signed-off-by: Fanit Kolchina <[email protected]> * Fix links Signed-off-by: Fanit Kolchina <[email protected]> * One more link fix Signed-off-by: Fanit Kolchina <[email protected]> * Update spec-insert to resolve the checks error Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]> (cherry picked from commit 6f86f2b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Prepare for migration from /docs/latest to /latest * Fix hardcoded link * Fix links * One more link fix * Update spec-insert to resolve the checks error --------- (cherry picked from commit 6f86f2b) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Zhu <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-3.0 3.0
# Navigate to the new working tree
pushd ../.worktrees/backport-3.0
# Create a new branch
git switch --create backport/backport-10324-to-3.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6f86f2b9b6a34af90ccdc6e0d25df0d16c5caddc
# Push it to GitHub
git push --set-upstream origin backport/backport-10324-to-3.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-3.0Then, create a pull request where the |
Prepare for migration from /docs/latest to /latest
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.