Skip to content

adding example to otel traces #11354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2025
Merged

adding example to otel traces #11354

merged 4 commits into from
Nov 11, 2025

Conversation

@AntonEliatra
Copy link
Contributor

@AntonEliatra AntonEliatra commented Oct 21, 2025

Description

adding example to otel traces

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@AntonEliatra
Copy link
Contributor Author

AntonEliatra commented Oct 21, 2025

@dlvenable could you please review this PR?

@kolchfa-aws
Copy link
Collaborator

kolchfa-aws commented Oct 21, 2025

@dlvenable Could you review this PR?

@kolchfa-aws kolchfa-aws added Tech review PR: Tech review in progress backport 3.3 labels Oct 21, 2025
dlvenable
dlvenable reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AntonEliatra . This looks good overall. The only comment in on the double quotes.

dlvenable
dlvenable approved these changes Nov 11, 2025
View reviewed changes
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AntonEliatra !

@kolchfa-aws kolchfa-aws added Editorial review PR: Editorial review in progress and removed Tech review PR: Tech review in progress labels Nov 11, 2025
@kolchfa-aws kolchfa-aws assigned natebower and unassigned dlvenable Nov 11, 2025
natebower
natebower approved these changes Nov 11, 2025
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natebower natebower removed the Editorial review PR: Editorial review in progress label Nov 11, 2025
@natebower natebower merged commit 9c0de56 into opensearch-project:main Nov 11, 2025
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 11, 2025
@github-actions @kolchfa-aws
adding example to otel traces (#11354)
1402fc3 
* adding example to otel traces

Signed-off-by: Anton Rubin <[email protected]>

* Update otel-trace-source.md

Signed-off-by: AntonEliatra <[email protected]>

* Update otel-trace-source.md

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 9c0de56)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 11, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Nov 11, 2025
@opensearch-trigger-bot
adding example to otel traces (#11354) (#11524)
b836ba4
@AntonEliatra AntonEliatra deleted the adding-example-to-otel-traces branch November 12, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws left review comments

@dlvenable dlvenable dlvenable approved these changes

@natebower natebower natebower approved these changes

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

@sumobrian sumobrian Awaiting requested review from sumobrian sumobrian is a code owner

Assignees

@natebower natebower

@kolchfa-aws kolchfa-aws

Labels

backport 3.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AntonEliatra @kolchfa-aws @dlvenable @natebower