[Enhancement] Enhance validation for create connector API #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolarkunnu
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
reviewed
Feb 21, 2025
common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java
Outdated
Show resolved
Hide resolved
pyek-bot
reviewed
Feb 21, 2025
common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java
Outdated
Show resolved
Hide resolved
pyek-bot
reviewed
Feb 21, 2025
common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java
Show resolved
Hide resolved
pyek-bot
reviewed
Feb 21, 2025
common/src/main/java/org/opensearch/ml/common/connector/HttpConnector.java
Show resolved
Hide resolved
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
|
Can anyone trigger the failed test suite once more, failure doesn't have any relation with changes. |
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
|
@zane-neo Can you please look in o these two failures, my changes around prepostProcessFunctions:
I am not able to reproduce and debug these failures locally because of below dependencies: The AWS credentials are not set. Skipping test.COHERE_KEY is null, skipping the test! |
Please rebase the latest code on main branch, this has been fixed. |
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
|
linux (23) - Known flaky org.opensearch.ml.rest.RestMLRemoteInferenceIT.testPredictWithAutoDeployAndTTL_RemoteModel #3544 linux (21) - There are no real failures Windows (21) - org.opensearch.ml.rest.RestMLRAGSearchProcessorIT.testBM25WithBedrockConverse - not related the code changes |
|
Hi Maintainers, Please help to move forward this task. |
Hi @akolarkunnu, let me review this PR and test out some of the changes. In the meanwhile, the maintainers can help re-trigger the CI and we can check if it goes through? Thanks for the fix and sharing the test details! |
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
reviewed
Mar 14, 2025
...ithms/src/test/java/org/opensearch/ml/engine/algorithms/remote/AwsConnectorExecutorTest.java
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java
Outdated
Show resolved
Hide resolved
This change will address the second part of validation "pre and post processing function validation". Partially resolves opensearch-project#2993 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
|
Please approve for CI - "Waiting for review: ml-commons-cicd-env-require-approval needs approval to start deploying changes." |
|
Hi Maintainers, @pyek-bot Please approve to run CI. |
pyek-bot
reviewed
Mar 20, 2025
common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java
Show resolved
Hide resolved
dhrubo-os
reviewed
Mar 21, 2025
common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java
Show resolved
Hide resolved
dhrubo-os
reviewed
Mar 21, 2025
common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java
Show resolved
Hide resolved
dhrubo-os
reviewed
Mar 21, 2025
common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java
Outdated
Show resolved
Hide resolved
dhrubo-os
reviewed
Mar 21, 2025
common/src/test/java/org/opensearch/ml/common/connector/ConnectorActionTest.java
Outdated
Show resolved
Hide resolved
This change will address the second part of validation "pre and post processing function validation". Partially resolves opensearch-project#2993 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Active
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will address the second part of validation "pre and post processing function validation".
Moved the method getRemoteServerFromURL() from ConnectorUtils.java to ConnectorAction.java, to avoid the cyclic dependency
Related Issues
Partially resolves #2993
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.