Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries for PredictionITTests #3642

Conversation

rithin-pullela-aws
Copy link
Contributor

Description

Created a new junit test rule for retries, the PredictionITTests are flaky and the retry logic resolves the issue

The reason for creating the retry rule is to simulate all the before and after methods related to a test case

Related Issues

Resolves #3550

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Created a new junit test rule for retries, the PredictionITTests are flaky and the retry logic resolves the issue

Signed-off-by: rithin-pullela-aws <[email protected]>
@zane-neo
Copy link
Collaborator

The new file is missing license header:

Files with unapproved licenses:
> Task :opensearch-ml-plugin:licenseHeaders FAILED

  /__w/ml-commons/ml-commons/plugin/src/test/java/org/opensearch/ml/utils/RetryRule.java

@rithin-pullela-aws please take a look.

@rithin-pullela-aws
Copy link
Contributor Author

The new file is missing license header:

Files with unapproved licenses:
> Task :opensearch-ml-plugin:licenseHeaders FAILED

  /__w/ml-commons/ml-commons/plugin/src/test/java/org/opensearch/ml/utils/RetryRule.java

@rithin-pullela-aws please take a look.

Thank you @zane-neo, will have a look

@rithin-pullela-aws
Copy link
Contributor Author

Closing this PR since retry is a workaround and the root cause has been found. Will raise another PR resolving the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Flaky Test] PredictionITTests are being flaky
2 participants