Add LogicalSystemLimit automatically for data-intensive operations #3749
+789
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
noCharger and
qianheng-aws
as code owners
penghuo
reviewed
Jun 9, 2025
...earch/src/main/java/org/opensearch/sql/opensearch/storage/scan/AbstractCalciteIndexScan.java
Show resolved
Hide resolved
...search/src/main/java/org/opensearch/sql/opensearch/storage/scan/CalciteLogicalIndexScan.java
Outdated
Show resolved
Hide resolved
...arch/src/main/java/org/opensearch/sql/opensearch/planner/physical/SystemLimitRuleConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
|
penghuo
previously approved these changes
Jun 10, 2025
penghuo
reviewed
Jun 10, 2025
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
changed the title
Signed-off-by: Lantao Jin <[email protected]>
|
@penghuo @qianheng-aws @dai-chen I have updated the description with new code refactor, and docs. please take another look. |
This was referenced Jun 12, 2025
|
This PR is stalled because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From v3.0.0, PPL introduces commands that may increase data volume. To prevent out-of-memory problem, the system automatically enforces a
LogicalSystemLimitoperator for such commands.plugins.query.system_limit: The size configures the maximum of rows in the subsearch to data-intensive operations against (e.g. join, lookup). The default value is: 50000. Value range is from 0 to 2147483647 (Int.MaxValue).Update
Now, all PPL join/lookup/expand commands (data-bloat) will be affected by this PR. In future, we can add more command argument to control specific command.
For Join, when join type is
LogicalSystemLimitoperator to left side (main-search)LogicalSystemLimitoperator to right side (sub-search)For Lookup
LogicalSystemLimitoperator to right side (sub-search)For expand
LogicalSystemLimitoperator to right side (sub-search)The results of impacted search (for example, the lookup table of lookup command, right side of inner join, etc.)
cannot exceed the limitation (50000 rows by default). If the actual number of rows in lookup table or right side
of inner join is greater then the system limit, only the number of rows specified by the configuration will be searched.
You can set the configuration to the maximum integer value (2147483647) if you are certain resources are not a concern.
Related Issues
Resolves #3731
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.