Update big5 ppl queries and check plans #4668
Merged
+3,175
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
added
bug
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
|
@noCharger please view this update and we might need to update our benchmark as well. |
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
changed the title
|
for queries defined big5/queries/optimized/, we should updated in opensearch-benchmark repo? |
penghuo
reviewed
Oct 28, 2025
| protected String loadExpectedQuery(String fileName) throws IOException { | ||
| if (isCalciteEnabled()) { | ||
| try { | ||
| return loadFromFile("big5/queries/optimized/" + fileName); |
There was a problem hiding this comment.
why have optimized folder? it required calcite enable?
IMO, PPL big5 query should be optimized queries.
There was a problem hiding this comment.
That because 1. bucket_nullable argument, 2. bin command
Yes. cc @noCharger and @xinyual |
yuancu
approved these changes
Oct 28, 2025
qianheng-aws
approved these changes
Oct 28, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
* Update big5 ppl queries Signed-off-by: Lantao Jin <[email protected]> * Add explain check for big5 queries Signed-off-by: Lantao Jin <[email protected]> * update to latest code base Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit 0f45382) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin
pushed a commit
that referenced
this pull request
Oct 28, 2025
* Update big5 ppl queries * Add explain check for big5 queries * update to latest code base --------- (cherry picked from commit 0f45382) Signed-off-by: Lantao Jin <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update big5 ppl queries:
big5/queries/optimized/:CalcitePPLBig5ITfirst loads the ppl file from this folder. If it cannot be found, it loads the ppl file frombig5/queries/.statsin this folder will setbucket_nullable = falseto align with related DSL.auto-date-histogram,rangeandmulti-termsbucket aggregation.head 10OR.Related Issues
Resolves #4667
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.