Support 'usenull' option in PPL top and rare commands
#4696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
penghuo
approved these changes
Oct 29, 2025
Comment on lines
+31
to
+32
| * When ``plugins.ppl.syntax.legacy.preferred=true``, ``usenull`` defaults to ``true`` | ||
| * When ``plugins.ppl.syntax.legacy.preferred=false``, ``usenull`` defaults to ``false`` |
There was a problem hiding this comment.
bullet points in blockquote, is it expected?
There was a problem hiding this comment.
Yes. Keep the format same with the current stats.rst. I tried to use the new format to align with Update PPL Command Documentation. But seems there are still many format problems in that PR. ref
qianheng-aws
approved these changes
Oct 30, 2025
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4696-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c6a5fb9762aed964fe56513b80a55f35934b0255
# Push it to GitHub
git push --set-upstream origin backport/backport-4696-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
yuancu
reviewed
Oct 30, 2025
Comment on lines
+1875
to
+1879
| context.relBuilder.filter( | ||
| PlanUtils.getSelectColumns(groupByList).stream() | ||
| .map(context.relBuilder::field) | ||
| .map(context.relBuilder::isNotNull) | ||
| .toList()); |
There was a problem hiding this comment.
Why not apply isNotNull directly on groupByList, but on their underlying input ref? If some operation converts a null field to a non-null one, I think it should not be filtered out.
There was a problem hiding this comment.
@yuancu
Think about query:
| eval a = nullif(status, "200") | stats bucket_nullable = false count() by a
The groupByList contains RexCall "AS($9, 'a')". So we finally build a
context.relBuilder.filter(isNotNull($9)) which $9 is nullif(status, "200") instead of status
LantaoJin
added a commit
to LantaoJin/search-plugins-sql
that referenced
this pull request
Oct 30, 2025
…-project#4696) * Support 'usenull' option in PPL top and rare commands Signed-off-by: Lantao Jin <[email protected]> * fix the incorrect naming Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit c6a5fb9)
LantaoJin
added a commit
that referenced
this pull request
Oct 30, 2025
…commands (#4696) (#4702) * Support 'usenull' option in PPL `top` and `rare` commands (#4696) * Support 'usenull' option in PPL top and rare commands Signed-off-by: Lantao Jin <[email protected]> * fix the incorrect naming Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit c6a5fb9) * fix compile error Signed-off-by: Lantao Jin <[email protected]> * fix compile error Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
usenullis determined byplugins.ppl.syntax.legacy.preferred:plugins.ppl.syntax.legacy.preferred=true,usenulldefaults totrueplugins.ppl.syntax.legacy.preferred=false,usenulldefaults tofalseSee #4684 for examples.
Related Issues
Resolves #4684
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.