Updated Meshtastic Driver for Successful Migration to OSH-Addons #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalynstricklin
suggested changes
Nov 13, 2025
Contributor
kalynstricklin
left a comment
kalynstricklin
left a comment
There was a problem hiding this comment.
this is a good driver, i would just keep it consistent with naming and follow one convention instead of mixing them.
- field names should be lower camel case
- definitions should be upper camel case
...hers/sensorhub-driver-meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/Config.java
Outdated
Show resolved
Hide resolved
...meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/MeshtasticControlTextMessage.java
Outdated
Show resolved
Hide resolved
...hub-driver-meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/MeshtasticHandler.java
Outdated
Show resolved
Hide resolved
...hub-driver-meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/MeshtasticHandler.java
Outdated
Show resolved
Hide resolved
...iver-meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/MeshtasticOutputGeneric.java
Outdated
Show resolved
Hide resolved
...iver-meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/MeshtasticOutputGeneric.java
Outdated
Show resolved
Hide resolved
...ver-meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/MeshtasticOutputNodeInfo.java
Outdated
Show resolved
Hide resolved
...ver-meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/MeshtasticOutputNodeInfo.java
Outdated
Show resolved
Hide resolved
...r-meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/MeshtasticOutputPacketInfo.java
Outdated
Show resolved
Hide resolved
...rs/sensorhub-driver-meshtastic/src/test/java/com/sample/impl/sensor/meshtastic/TestBase.java
Outdated
Show resolved
Hide resolved
…he 'destination' field
earocorn
reviewed
Nov 14, 2025
...hers/sensorhub-driver-meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/Config.java
Outdated
Show resolved
Hide resolved
...meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/MeshtasticControlTextMessage.java
Outdated
Show resolved
Hide resolved
...r-meshtastic/src/main/java/org/sensorhub/impl/sensor/meshtastic/MeshtasticOutputGeneric.java
Outdated
Show resolved
Hide resolved
...rhub-driver-meshtastic/src/main/java/com/sample/impl/sensor/meshtastic/MeshtasticSensor.java
Outdated
Show resolved
Hide resolved
...b-driver-meshtastic/src/main/java/org/sensorhub/impl/sensor/meshtastic/MeshtasticSensor.java
Outdated
Show resolved
Hide resolved
...b-driver-meshtastic/src/main/java/org/sensorhub/impl/sensor/meshtastic/MeshtasticSensor.java
Outdated
Show resolved
Hide resolved
...b-driver-meshtastic/src/main/java/org/sensorhub/impl/sensor/meshtastic/MeshtasticSensor.java
Outdated
Show resolved
Hide resolved
...-driver-meshtastic/src/test/java/com/sample/impl/sensor/meshtastic/MeshtasticSensorTest.java
Outdated
Show resolved
Hide resolved
…ated the UID prefix to be more general on Sensor
…tion created with multiple names in previous code
… auto generated these files upon build
…h-addons into MeshtasticDriver
nickgaray
requested changes
Nov 24, 2025
...b-driver-meshtastic/src/main/java/org/sensorhub/impl/sensor/meshtastic/MeshtasticSensor.java
Outdated
Show resolved
Hide resolved
nickgaray
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.