Added Git Service

[Lucifergene]

Test setup:

1. Deploy to a kind cluster

make deploy

2. Apply the ConsoleApplication YAML:

apiVersion: apps.console.dev/v1alpha1
kind: ConsoleApplication
metadata:
  name: github-successes
  namespace: avik
  labels:
    app.openshift.io/name: github-success
spec:
  applicationName: github-success-app
  git:
    url: https://github.com/openshift-console/console-application-operator
    contextDir: /
    reference: main
  importStrategy: builder-image
  buildConfiguration:
    builderImage:
      name: golang
      image: docker.io/hello/golang:latest
    buildOption: BuildConfig
    env:
      - name: hello
        value: world
  deploymentConfiguration:
    resourceType: deployment
    env:
      - name: hello
        value: world
    expose:
      targetPort: 8080
      createRoute: true

3. Check the status of the ConsoleApplication

[mfrancisc]

Great job 👍 I like how you structured the project and long list of functionality you added already 👏

I have left few minor comments, but I haven't yet finished reviewing the tests.

[mfrancisc]

not sure I understand why updating the status here ? There's no condition you are setting . Are you resetting the conditions ? In that case I don't think it's needed. We can keep those there and update them only.

[Lucifergene]

I think it seems that I am creating an empty condition slice and updating the status with that. But the SetStarted function is adding a status condition "Progressing".

// SetStarted sets the Operator Progressing condition to True.
func SetStarted(consoleApplication *appsv1alpha1.ConsoleApplication) {
	meta.SetStatusCondition(&consoleApplication.Status.Conditions, metav1.Condition{
		Type:               appsv1alpha1.ConditionProgressing.String(),
		Status:             metav1.ConditionTrue,
		Reason:             "RequirementsBeingMet",
		LastTransitionTime: metav1.NewTime(time.Now()),
		Message:            "Requirements are being met",
	})
}

Does this work? Or am I not getting it?

[Lucifergene]

Due to the complexities of having the "Progressing" status condition, I have currently moved forward with having solely the "Ready" status condition to inform users whether the application is created or is it in processing.

[mfrancisc]

Also I see the project now allows to merge without approval. Should we configure it so that it requires one approval for merging ?

[mfrancisc]

Looks great 👏 🥇

Awesome job!