Add oc-mirror-2.0 to PRODUCT_KUBECONFIG_MAP - #3182
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift-eng/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe exported product mappings now include ChangesProduct kubeconfig support
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
32eab89 to
18f55fd
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@artcommon/artcommonlib/constants.py`:
- Line 135: Add an explicit "oc-mirror-2.0" entry to the kubeconfig mapping
alongside the existing "oc-mirror" entry, mapping it to KONFLUX_SA_KUBECONFIG so
resolve_konflux_kubeconfig_by_product() resolves both product names identically.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift-eng/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6efbd0bf-2f91-4fdb-b428-b743f939908e
📒 Files selected for processing (1)
artcommon/artcommonlib/constants.py
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Add explicit "oc-mirror-2.0" entry to the kubeconfig mapping alongside "oc-mirror", mapping it to KONFLUX_SA_KUBECONFIG so resolve_konflux_kubeconfig_by_product() resolves both product names identically. Add unit tests in artcommon to verify product-based resolution for both variants. Co-Authored-By: Gemini CLI <noreply@google.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
f6c9434 to
9c716dc
Compare
|
@ashwindasr: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
oc-mirror-2.0toPRODUCT_KUBECONFIG_MAPinartcommon/artcommonlib/constants.py, mapped toKONFLUX_SA_KUBECONFIGTest plan
PRODUCT_KUBECONFIG_MAP["oc-mirror-2.0"]returns"KONFLUX_SA_KUBECONFIG"🤖 Generated with Claude Code
Summary by CodeRabbit