Skip to content

Fix CoreOS image mirroring to use ocp-priv namespace#3194

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
fgallott:fix-ocp-private
Jul 23, 2026
Merged

Fix CoreOS image mirroring to use ocp-priv namespace#3194
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
fgallott:fix-ocp-private

Conversation

@fgallott

@fgallott fgallott commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Test Platform moved from ocp-private to ocp-priv, causing build-sync-konflux to fail when tagging CoreOS images for private CI.

Summary by CodeRabbit

  • Bug Fixes
    • Updated private CI image tagging to use the correct ocp-priv image stream and namespace.
    • Improved related logging to accurately reflect the updated destination.

Test Platform renamed the namespace from ocp-private to ocp-priv,
causing build-sync to fail when tagging CoreOS images for private CI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED

@joepvd joepvd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift-eng/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fa11594a-8ce1-4a4e-bd51-c2487d1bc32b

📥 Commits

Reviewing files that changed from the base of the PR and between 80d2c9d and b1f5f88.

📒 Files selected for processing (1)
  • pyartcd/pyartcd/pipelines/build_sync.py

Walkthrough

Changes

Private CI tagging

Layer / File(s) Summary
Update private CI target
pyartcd/pyartcd/pipelines/build_sync.py
The private CI tagging branch now targets ocp-priv and updates its log message; the remaining command structure is unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: locriandev

🚥 Pre-merge checks | ✅ 9 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Ai-Attribution ⚠️ Warning HEAD commit credits Claude via Co-Authored-By, but no Assisted-by or Generated-by trailer is present. Replace AI attribution with a Red Hat-style Assisted-by or Generated-by trailer, and remove Co-Authored-By for the AI tool.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: switching CoreOS image mirroring to the ocp-priv namespace.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Weak-Crypto ✅ Passed The only change is an imagestream namespace rename; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or token comparisons are present.
Container-Privileges ✅ Passed PR only changes a Python imagestream namespace string; no container/K8s manifests or privilege-related settings were added or modified.
No-Sensitive-Data-In-Logs ✅ Passed The only log change renames ocp-private to ocp-priv; it doesn't add secrets, tokens, PII, or hostnames.
No-Hardcoded-Secrets ✅ Passed The only code changes are ocp-private→ocp-priv namespace literals; no hardcoded secrets, base64 blobs, or credential-bearing strings were added.
No-Injection-Vectors ✅ Passed Only a literal namespace/log string changed; commands still go through cmd_gather_async/create_subprocess_exec, with no new eval/shell/pickle/YAML/HTML sinks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 8148432 into openshift-eng:main Jul 23, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants