Bump sharp and wrangler in /art-cluster/cloudflare#3200
Conversation
Bumps [sharp](https://github.com/lovell/sharp) to 0.35.2 and updates ancestor dependency [wrangler](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/wrangler). These dependencies need to be updated together. Updates `sharp` from 0.33.5 to 0.35.2 - [Release notes](https://github.com/lovell/sharp/releases) - [Commits](lovell/sharp@v0.33.5...v0.35.2) Updates `wrangler` from 4.14.1 to 4.114.0 - [Release notes](https://github.com/cloudflare/workers-sdk/releases) - [Commits](https://github.com/cloudflare/workers-sdk/commits/wrangler@4.114.0/packages/wrangler) --- updated-dependencies: - dependency-name: sharp dependency-version: 0.35.2 dependency-type: indirect - dependency-name: wrangler dependency-version: 4.114.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughThe Cloudflare package updates its Wrangler development dependency from ChangesCloudflare Dependency Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@art-cluster/cloudflare/package.json`:
- Line 14: Update the wrangler dependency declaration in package.json from a
caret range to the exact version 4.114.0, and preserve the existing lockfile
entry without changing its resolved version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift-eng/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 59dba432-9a13-4d34-b342-963563dd71a8
⛔ Files ignored due to path filters (1)
art-cluster/cloudflare/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
art-cluster/cloudflare/package.json
| "@types/node": "^22.7.4", | ||
| "typescript": "^5.0.4", | ||
| "wrangler": "^4.14.1" | ||
| "wrangler": "^4.114.0" |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
jq -e '.devDependencies.wrangler == "4.114.0"' \
art-cluster/cloudflare/package.json
jq -e '.packages["node_modules/wrangler"].version == "4.114.0"' \
art-cluster/cloudflare/package-lock.json
curl -fsS -X POST https://api.osv.dev/v1/query \
-H 'content-type: application/json' \
--data '{"package":{"name":"wrangler","ecosystem":"npm"},"version":"4.114.0"}' |
jq .Repository: openshift-eng/art-tools
Length of output: 167
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "package.json:"
nl -ba art-cluster/cloudflare/package.json | sed -n '1,80p'
echo
echo "package-lock.json wrangler entries:"
rg -n '"wrangler"|node_modules/wrangler|4\.114\.0' art-cluster/cloudflare/package-lock.jsonRepository: openshift-eng/art-tools
Length of output: 215
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "package.json:"
cat -n art-cluster/cloudflare/package.json | sed -n '1,80p'
echo
echo "package-lock.json wrangler entries:"
rg -n '"wrangler"|node_modules/wrangler|4\.114\.0' art-cluster/cloudflare/package-lock.jsonRepository: openshift-eng/art-tools
Length of output: 1024
Pin Wrangler to an exact version
art-cluster/cloudflare/package.json:14 still uses ^4.114.0, so future 4.x releases can slip in when the lockfile is refreshed. Change it to "wrangler": "4.114.0" and keep the current lockfile entry.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@art-cluster/cloudflare/package.json` at line 14, Update the wrangler
dependency declaration in package.json from a caret range to the exact version
4.114.0, and preserve the existing lockfile entry without changing its resolved
version.
Source: Path instructions
Bumps sharp to 0.35.2 and updates ancestor dependency wrangler. These dependencies need to be updated together.
Updates
sharpfrom 0.33.5 to 0.35.2Release notes
Sourced from sharp's releases.
... (truncated)
Commits
c9622a3Release v0.35.2cd4568fUpgrade to sharp-libvips v1.3.178390cfTests: Add font file to prevent font discovery flakiness (#4550)61210b4Verify convolve kernel values are numbers (#4549)1cb27dcPrerelease v0.35.2-rc.2c7606c3Upgrade to sharp-libvips v1.3.1-rc.029d1e9ePrerelease v0.35.2-rc.1bbba0a1Improve code bundler support with stub binariesab52866Bound dilate and erode width to avoid mask-size overflow (#4548)0f594ddPrerelease v0.35.2-rc.0Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for sharp since your current version.
Updates
wranglerfrom 4.14.1 to 4.114.0Release notes
Sourced from wrangler's releases.
... (truncated)
Commits
16b3d5aVersion Packages (#14799)3203b5d[miniflare] Local dev observability: traces, spans & logs via a SQL query API...246ce92[wrangler] Improve d1 create database-limit error message (#14373)02232f3[wrangler] compare origins, not hrefs, when classifying dev proxy fetch error...8416b33[wrangler] Fix grammar in container image-too-large error (#14788)f8a8c2c[wrangler] Explain missing Flagship app ID (#14797)88f42e7Version Packages (#14740)9e61971unskip agent memory remote bindings test (#14786)0df3d43[wrangler] Extract remote bindings into a package (#14720)4815711[miniflare] Report the Worker's error for HEAD requests (#14766)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for wrangler since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit