Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jhipster-online project #1737

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Conversation

maximilianoPizarro
Copy link
Contributor

@maximilianoPizarro maximilianoPizarro commented Feb 21, 2025

add OWNERS for jhipster-online tested on Developer Sandbox and DevSpaces.

Signed-off-by: Maximiliano Pizarro <[email protected]>
Copy link
Contributor

Submission Facts Mismatch

The content of the OWNERS file and your submission path do not seem to match. Double check that
your vendor label and chart name values in your OWNERS file match with your submission path.

This comment was auto-generated by GitHub Actions.

Copy link
Contributor

Thank you for submitting PR #1737 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[ERROR] PR includes one or more files not related to charts, e.g., charts/community/jhipster/jhipster-online/OWNERS

[ERROR] Send OWNERS file by itself in a separate PR.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "jhipster", "chart_name": "jhipster-online"}

Copy link
Contributor

Submission Facts Mismatch

The content of the OWNERS file and your submission path do not seem to match. Double check that
your vendor label and chart name values in your OWNERS file match with your submission path.

This comment was auto-generated by GitHub Actions.

Copy link
Contributor

Thank you for submitting PR #1737 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[ERROR] PR includes one or more files not related to charts, e.g., charts/community/jhipster/jhipster-online/OWNERS

[ERROR] Send OWNERS file by itself in a separate PR.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "jhipster", "chart_name": "jhipster-online"}

@maximilianoPizarro
Copy link
Contributor Author

Hi! I've tried to upload the OWNERS file in a separate PR without success, this is a community artifact. Happy Recharge Day!

@komish
Copy link
Collaborator

komish commented Feb 21, 2025

Happy Recharge Day!

I don’t see an open PR containing just the owners file, and that must be merged before a chart submission can be accepted. Further, net new community charts require manual approval. Please send that pull request first, and after maintainers review and merge, then this will need to be rebased on main.

I saw the a closed PR, feel free to either reopen that or submit a new one.

Signed-off-by: Maximiliano Pizarro <[email protected]>
Copy link
Contributor

🔓 Maintainers:

The OWNERS file contributed here has a chart name that is AVAILABLE!

The chart name 'jhipster-online' does not appear in our lockfile.

After reviewing this pull request, please re-run this workflow once more before merging.

This comment was auto-generated by GitHub Actions.

Copy link
Contributor

🔓 Maintainers:

The OWNERS file contributed here has a chart name that is AVAILABLE!

The chart name 'jhipster-online' does not appear in our lockfile.

After reviewing this pull request, please re-run this workflow once more before merging.

This comment was auto-generated by GitHub Actions.

Copy link
Contributor

Thank you for submitting PR #1737 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[INFO] OWNERS file changes require manual review by maintainers.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "", "chart_name": ""}

1 similar comment
Copy link
Contributor

Thank you for submitting PR #1737 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[INFO] OWNERS file changes require manual review by maintainers.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "", "chart_name": ""}

@maximilianoPizarro
Copy link
Contributor Author

Happy Recharge Day!

I don’t see an open PR containing just the owners file, and that must be merged before a chart submission can be accepted. Further, net new community charts require manual approval. Please send that pull request first, and after maintainers review and merge, then this will need to be rebased on main.

I saw the a closed PR, feel free to either reopen that or submit a new one.

Hi @komish! Thanks for your prompt reply. I've updated this PR with only the OWNERS file. If you're happy with it, we can move forward with this and I'll add the version and report.yaml in the next PR.

I look forward to the comments.

Signed-off-by: Maximiliano Pizarro <[email protected]>
Copy link
Contributor

Thank you for submitting PR #1737 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[INFO] OWNERS file changes require manual review by maintainers.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "", "chart_name": ""}

Copy link
Contributor

🔓 Maintainers:

The OWNERS file contributed here has a chart name that is AVAILABLE!

The chart name 'jhipster-online' does not appear in our lockfile.

After reviewing this pull request, please re-run this workflow once more before merging.

This comment was auto-generated by GitHub Actions.

Signed-off-by: Maximiliano Pizarro <[email protected]>
Copy link
Contributor

🔓 Maintainers:

The OWNERS file contributed here has a chart name that is AVAILABLE!

The chart name 'jhipster-online' does not appear in our lockfile.

After reviewing this pull request, please re-run this workflow once more before merging.

This comment was auto-generated by GitHub Actions.

Copy link
Contributor

Thank you for submitting PR #1737 for Helm Chart Certification!

Outcome:

Failed

Detail

One or more errors were found with the pull request:

[INFO] OWNERS file changes require manual review by maintainers.

Task Insights

Here are the outcomes of tasks driving this result.

task outcome
PR Content Check failure
Run Chart Verifier skipped
Result Verification skipped
OpenShift Client Installation skipped

For information on the certification process see:

/metadata {"vendor_label": "", "chart_name": ""}

Copy link
Collaborator

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@komish komish merged commit 878218a into openshift-helm-charts:main Feb 24, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants