Allow to use custom registerer for metrics #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpasquier
commented
Mar 17, 2025
|
While tests exist, they aren't gating the pull request:
|
See #9 |
simonpasquier
force-pushed
the
allow-custom-registry
branch
from
8f5a5da to
9538228
Compare
tzvatot
requested changes
Apr 17, 2025
simonpasquier
force-pushed
the
allow-custom-registry
branch
2 times, most recently
from
902bdf1 to
4d06e86
Compare
tzvatot
requested changes
Apr 22, 2025
It's a good practice that libraries don't impose the use of the global Prometheus registry. While convenient, it complicates the integration if the application using aysnc-router prefers to use a custom registry. This commit also adds unit tests for the metrics observer. Signed-off-by: Simon Pasquier <[email protected]>
simonpasquier
force-pushed
the
allow-custom-registry
branch
from
4d06e86 to
97b2c61
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a good practice that libraries don't impose the use of the global Prometheus registry. While convenient, it complicates the integration if the application using aysnc-router prefers to use a custom registry.