fix(controllers): requeue on gate conditions instead of relying on watch events

[cristianoveiga]

Summary

• HC and nodepool controller gates (placement not ready, HC not available, VR not ready, version mismatch) returned reconcile.Result{} with no requeue, relying entirely on watch events to re-trigger reconciliation
• If no watch event fired (e.g. no update to the cluster object), the controller would stall indefinitely
• All gates now return RequeueAfter: 15s so controllers periodically re-check gate conditions

Test plan

• All existing HC controller tests updated and passing
• All existing nodepool controller tests updated and passing
• Verify in dev environment that stuck nodepools recover within 15s

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved recovery when cluster placement, availability, or release version information is not yet ready.
  • Systems now retry reconciliation every 15 seconds when required information is missing or versions do not match.
  • Conflict-handling scenarios also retry automatically, reducing the need to wait for unrelated updates.
  • Status reporting and existing error handling remain unchanged.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift-online/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 81d5f813-40ba-4131-9b1b-d87e9f19d43d

📥 Commits

Reviewing files that changed from the base of the PR and between d749122 and dd4e783.

📒 Files selected for processing (2)

• controllers/hc/hc_controller.go
• controllers/nodepool/nodepool_controller.go

🚧 Files skipped from review as they are similar to previous changes (2)

• controllers/nodepool/nodepool_controller.go
• controllers/hc/hc_controller.go

Included review availability: Your plan includes up to 12 reviews per rolling hour; 10 remain after this review.

---

Walkthrough

HostedCluster and NodePool reconciliation now explicitly requeue after 15 seconds when placement, availability, or version prerequisites are not ready. Tests now expect these requeue results, including status-update conflict cases.

Changes

Reconciliation requeues

Layer / File(s)	Summary
Controller requeue logic controllers/hc/hc_controller.go, controllers/nodepool/nodepool_controller.go	HostedCluster and NodePool reconciliation return timed requeues for unavailable placement, HostedCluster readiness, unresolved versions, and version mismatches.
Requeue test coverage controllers/hc/hc_controller_test.go, controllers/nodepool/nodepool_controller_test.go	Tests expect timed requeues for pending prerequisite checks and status-update conflict paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to dd4e7

The controllers now periodically recheck gate conditions instead of relying only on watch events; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: patjlm, acwalczyk

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Ai-Attribution	⚠️ Warning	AI use is explicit in the PR and commits; all three changed commits use Co-Authored-By: Claude Opus 4.6, with no Assisted-by or Generated-by trailer.	Replace the AI Co-Authored-By trailers with the required Red Hat Assisted-by or Generated-by attribution trailers.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: timed requeues for controller gate conditions instead of relying on watch events.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Weak-Crypto	✅ Passed	The PR changes requeue behavior, logs, tests, and deletion plumbing; added-line and AST scans found no weak crypto, custom crypto, or secret/token comparisons.
Container-Privileges	✅ Passed	The PR changes only HC and NodePool Go controllers. No container or Kubernetes manifest privilege settings were added or changed; existing settings use runAsNonRoot and allowPrivilegeEscalation: fa...
No-Sensitive-Data-In-Logs	✅ Passed	The PR changes existing gate log wording and timing only; it preserves pre-existing nodepool IDs and release versions and adds no passwords, tokens, API keys, PII, hostnames, or customer data.
No-Hardcoded-Secrets	✅ Passed	The PR diff adds only requeue logs/results and test expectations; no secret-like assignments, credentials, private keys, embedded credentials, or long base64 strings appear in added lines.
No-Injection-Vectors	✅ Passed	The PR changes only controller requeue/log behavior and test expectations; changed lines introduce no SQL concatenation, shell/eval/exec, unsafe YAML/pickle, os.system, or HTML injection vectors.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristianoveiga, patjlm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cristianoveiga,patjlm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment