-
Notifications
You must be signed in to change notification settings - Fork 5
Hypershell-34 add security tools #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kdoberst
wants to merge
6
commits into
openshift-online:main
Choose a base branch
from
kdoberst:HYPERSHELL-34-add-security-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1f9bd82
Add security audit
kdoberst 82cf417
Add Skillspector and prodsec skills
kdoberst 91e4943
Merge branch 'main' into HYPERSHELL-34-add-security-tools
kdoberst af07b1b
fix: satisfy repository policy checks for security tooling
kdoberst 2be4bef
PR requested changes
kdoberst 3b97f57
Merge branch 'main' into HYPERSHELL-34-add-security-tools
kdoberst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| # SkillSpector baseline - suppress findings outside skill directories | ||
| # and false positives within skill directories. | ||
| version: 2 | ||
| rules: | ||
| # --- Directory exclusions (not agent skills) --- | ||
| - path: "apm_modules/*" | ||
| reason: "Upstream dependencies - audited separately by package maintainers" | ||
| - path: "components/*" | ||
| reason: "Application source code - not agent skills" | ||
| - path: "deploy/*" | ||
| reason: "Deployment manifests - not agent skills" | ||
| - path: "scripts/*" | ||
| reason: "Build/CI scripts - not agent skills" | ||
| - path: "specs/*" | ||
| reason: "Specification documents - not agent skills" | ||
| - path: "security-audit/*" | ||
| reason: "Security audit artifacts - not agent skills" | ||
| - path: ".threat-model-state/*" | ||
| reason: "Threat model working state - not agent skills" | ||
| - path: "DEVELOPMENT.md" | ||
| reason: "Project documentation - not an agent skill" | ||
| - path: "LICENSE" | ||
| reason: "License file - not an agent skill" | ||
| - path: "Makefile" | ||
| reason: "Build file - not an agent skill" | ||
| - path: "apm.lock.yaml" | ||
| reason: "Lockfile - not an agent skill" | ||
| - path: ".skillspector-reports/*" | ||
| reason: "Local SkillSpector scan output - not source code" | ||
|
|
||
| # --- False positives in skill/command scripts --- | ||
|
|
||
| # AST4: All subprocess calls use shell=False with explicit arg lists | ||
| # calling gh/git CLIs - the safe pattern the rule recommends. | ||
| - id: "AST4" | ||
| path: "*pr-hygiene/scripts/*" | ||
| reason: "subprocess.run with shell=False and hardcoded gh/git arg lists - no user-controlled input" | ||
| - id: "AST4" | ||
| path: "*pr-review/scripts/*" | ||
| reason: "subprocess.run with shell=False and hardcoded gh/git arg lists - no user-controlled input" | ||
|
|
||
| # AS3: Standard APM @claude/skills/ cross-references, not skill enumeration. | ||
| - id: "AS3" | ||
| path: "*commands/finish-work.md" | ||
| reason: "Standard APM skill reference syntax (@claude/skills/...), not enumeration" | ||
| - id: "AS3" | ||
| path: "*commands/start-work.md" | ||
| reason: "Standard APM skill reference syntax (@claude/skills/...), not enumeration" | ||
| - id: "AS3" | ||
| path: "*scored-code-review/SKILL.md" | ||
| reason: "Deprecation stub referencing replacement skill path, not enumeration" | ||
|
|
||
| # E2: Reads GH_TOKEN/GH_TOKEN_<org> for gh CLI auth - never logs values. | ||
| - id: "E2" | ||
| path: "*pr-hygiene/scripts/pr-hygiene.py" | ||
| reason: "Standard GitHub CLI token resolution for multi-org scanning - values never logged" | ||
|
|
||
| # EA2: Guide-only skill (presents commands, user executes) and Jira | ||
| # issue creation (the skill's purpose, with user confirmation). | ||
| - id: "EA2" | ||
| path: "*acm-release/SKILL.md" | ||
| reason: "Guide-only skill - presents commands for user to run, never executes them" | ||
| - id: "EA2" | ||
| path: "*jira-log/SKILL.md" | ||
| reason: "Creating Jira issues is the skill's purpose - user confirmation built into workflow" | ||
|
|
||
| # MP3: Coverage table documenting local-dev capabilities, not memory manipulation. | ||
| - id: "MP3" | ||
| path: "skills/RECONCILE.md" | ||
| reason: "Spec coverage table documenting dev-cluster features - no memory manipulation" | ||
|
|
||
| # PE3: Gap table mentioning kubeconfig as future architecture need, not credential access. | ||
| - id: "PE3" | ||
| path: "skills/RECONCILE.md" | ||
| reason: "Architecture gap table referencing kubeconfig as future work - no credential access" | ||
|
|
||
| # RA2: Writing a TUI keybinding config file - standard editor setup. | ||
| - id: "RA2" | ||
| path: "*opencode-setup/SKILL.md" | ||
| reason: "Writes tui.json keybinding config - standard editor setup, not session persistence" | ||
|
|
||
| # TM3: --tls-verify=false for OpenShift internal registry with self-signed certs | ||
| # on dev clusters - documented standard practice. | ||
| - id: "TM3" | ||
| path: "*deploy-cluster/SKILL.md" | ||
| reason: "OpenShift internal registry uses self-signed certs on dev clusters - documented practice" | ||
|
|
||
| # P1: Documentation describing kernel-level BPF capability, not an instruction override. | ||
| - id: "P1" | ||
| path: "*linux-capabilities/SKILL.md" | ||
| reason: "Reference documentation describing Linux capability behavior - not an agent instruction override" | ||
|
|
||
| # --- E2E test and CI false positives (not agent skills) --- | ||
|
|
||
| # E2: E2E test writes OIDC token from env into local openshell config (chmod 600). | ||
| - id: "E2" | ||
| path: "tests/e2e/e2e-openshell.sh" | ||
| reason: "E2E test harness - intentional OIDC token setup for openshell CLI, not env harvesting" | ||
|
|
||
| # PE3: E2E Kind driver acquires test credentials from local Keycloak. | ||
| - id: "PE3" | ||
| path: "tests/e2e/drivers/kind.sh" | ||
| reason: "E2E test harness - password grant against isolated Kind Keycloak with test credentials" | ||
|
|
||
| # TM2: CI installs upstream openshell CLI via documented install script. | ||
| - id: "TM2" | ||
| path: ".github/workflows/e2e.yml" | ||
| reason: "Accepted CI tradeoff - curl|sh installs OpenShell from upstream for e2e validation" | ||
|
|
||
| fingerprints: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run it once in my local and gave me a couple of security warnings
Then Calude analyzed the result and concluded that:
Both findings are false positives in test/CI files:
Both files are already in directories that should be excluded (tests/ and .github/), but the baseline only covers scripts/* and components/*, not those paths.
It suggests to add exclusions: