[HYPERSHELL-125] fix(control-plane): drop invalid Keycloak scopes from console OIDC - #171
Merged
Conversation
Remove gateway-roles from OAUTH2_PROXY_SCOPE and defaultClientScopes, and openid from defaultClientScopes. gateway-roles only exists in Kind's local Keycloak; federated realms reject it as invalid_scope. openid is implicit in the OIDC protocol, not a realm client scope. The dedicated client-roles mapper on each console client handles role mapping into hypershell.roles independently. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: openshift-online/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jsell-rh
enabled auto-merge
August 20, 2026 18:08
jsell-rh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway-rolesfromOAUTH2_PROXY_SCOPE— the scope doesn't exist on federated realms (e.g.ambient-code), causinginvalid_scopeon console logingateway-rolesandopenidfromdefaultClientScopeson Keycloak console clients —gateway-rolesdoesn't exist on federated realms;openidis implicit in the OIDC protocol, not a realm client scopedefaultClientScopesoccurrences (the other two were added by the console feature merge [HYPERSHELL-110] feat: per-gateway Gateway Console #147)client-rolesprotocol mapper on each console client handles role mapping intohypershell.rolesindependently of realm-level scopesTest plan
invalid_scoperolesscope handles role mapping)hypershell.rolesclaim is present in the access token after login🤖 Generated with Claude Code