Disable kube-proxy-sidecar by default and add documentation

[tiwillia]

Description

This disables the kube proxy sidecar by default and adds an AI-generated document describing the feature's intent and current state.

Given the feature expects kubeconfigs to be stored in AWS Secrets Manager and we intend to no longer require kubeconfigs directly one day through ZOA, its unclear whether this sidecar will actually be used in the future. Rather than remove the relevant code / implementation at this stage, this change simply ensures the default is to disable it.

Note that we may follow similar patterns to grant access to other credentials, which is my primary reason for leaving this around.

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Refactoring (no functional changes)
• CI/CD or tooling change

Testing

• Unit tests pass (make test-lambda, make test-lambda-create-investigation, make test-lambda-reap-tasks)
• Integration tests pass (if applicable)
• Manual verification completed

Checklist

• My code follows the project's coding conventions
• I have updated documentation as needed
• I have added tests that prove my fix/feature works
• All new and existing tests pass

Summary by CodeRabbit

• Bug Fixes
  • Regional deployments now disable the Kubernetes proxy by default when no explicit setting is provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clcollins for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fcb2cacb-08b7-42d0-adbc-fd24814dbf23

📥 Commits

Reviewing files that changed from the base of the PR and between 673b1e0 and 72e5987.

⛔ Files ignored due to path filters (1)

• docs/kube-proxy-sidecar.md is excluded by !**/*.md

📒 Files selected for processing (1)

• deploy/regional/Makefile

---

Walkthrough

The regional Makefile now defaults the exported TF_VAR_enable_kube_proxy Terraform variable to false when no environment or .env value is provided.

Changes

Regional kube-proxy default

Layer / File(s)	Summary
Update kube-proxy fallback deploy/regional/Makefile	Changes the fallback value of TF_VAR_enable_kube_proxy from true to false.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: theautoroboto

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Ai-Attribution	⚠️ Warning	PR mentions an AI-generated doc, but the sole commit has no Assisted-by/Generated-by trailer and no valid AI attribution.	Add a Red Hat AI attribution trailer (Assisted-by or Generated-by) to the commit or PR metadata; do not use Co-Authored-By for AI tools.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: disabling kube-proxy-sidecar by default, with documentation added as a secondary update.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Weak-Crypto	✅ Passed	PASS: Changes are Makefile/docs only; no weak-crypto code, custom crypto, or secret comparisons were added. SHA1 appears only as a certificate thumbprint in docs.
Container-Privileges	✅ Passed	Changed files are a Makefile and prose doc; neither introduces privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	No new logging was added; the PR only changes a Makefile default and adds docs. I found no runtime log statements exposing secrets or PII in the changed files.
No-Hardcoded-Secrets	✅ Passed	No hardcoded secrets were added; the change only flips a boolean default and adds docs/examples that reference Secrets Manager without embedding credentials.
No-Injection-Vectors	✅ Passed	Changed files only flip a Makefile default and add docs; scans found no eval/exec, yaml.load, pickle.loads, os.system, shell=True, or dangerous HTML.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov-appsre]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
go-unit-tests	8.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.