-
Notifications
You must be signed in to change notification settings - Fork 580
OPRUN-4246: Add BoxCutterRuntime feature gate #2577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPRUN-4246: Add BoxCutterRuntime feature gate #2577
Conversation
|
Pipeline controller notification For optional jobs, comment |
|
Hello @anik120! Some important instructions when contributing to openshift/api: |
|
@anik120: This pull request references OPRUN-4246 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
Scheduling tests matching the |
|
/jira refresh |
|
@perdasilva: This pull request references OPRUN-4246 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
d9e3f94 to
11f7307
Compare
|
/lgtm |
|
Scheduling tests matching the |
|
/retest-required |
11f7307 to
534d06a
Compare
|
/retest-required |
|
/lgtm |
|
Scheduling tests matching the |
|
/retest-required |
|
@anik120: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
everettraven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addition of the feature gate is correct and links to respective EP. That being said, it looks like the EP has not really undergone much review - before progressing too far in the implementation behind this gate I'd recommend ensuring you've informed the appropriate stakeholders and that they have signed off on the enhancement.
I won't block the addition of the feature gate on this. Worth mentioning as well that the approval of this feature gate is not an approval of the API changes in the EP - please separately request a review of any API changes for the EP.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label qe-approved |
|
@anik120: This pull request references OPRUN-4246 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bandrade: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
EP: openshift/enhancements#1890