Skip to content

OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default #858

wants to merge 1 commit into from

Conversation

@lance5890
Copy link
Contributor

@lance5890 lance5890 commented Aug 15, 2025

The BoundServiceAccountTokenVolume is enabled by default

kind of post-cleanup of openshift/kubernetes#714 and #531

@openshift-ci openshift-ci bot requested review from atiratree and deads2k August 15, 2025 23:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 15, 2025
@lance5890 lance5890 changed the title Use BoundServceAccountTokenVolume dy default OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default Aug 15, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 15, 2025

@lance5890: This pull request references Jira Issue OCPBUGS-60568, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The BoundServiceAccountTokenVolume is enabled by default

kind of post-cleanup of openshift/kubernetes#714 and #531

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lance5890
Copy link
Contributor Author

lance5890 commented Aug 17, 2025

the related pr openshift/cluster-version-operator#660 will block the upgrade

need more investigation

@lance5890
Copy link
Contributor Author

lance5890 commented Aug 17, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2025
@lance5890 lance5890 changed the title OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default WIP: OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default Aug 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2025
@lance5890 lance5890 mentioned this pull request Aug 18, 2025
Closed
@lance5890
Copy link
Contributor Author

lance5890 commented Aug 18, 2025

need to wait the openshift/cluster-version-operator#1225 to merge first

@lance5890 lance5890 changed the title WIP: OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default Aug 18, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
@tchap
Copy link
Contributor

tchap commented Nov 25, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 25, 2025
@tchap tchap mentioned this pull request Nov 26, 2025
Open
@tchap
Copy link
Contributor

tchap commented Nov 26, 2025

This is now blocked by openshift/cluster-version-operator#1264

@tchap
Copy link
Contributor

tchap commented Nov 26, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@tchap: This pull request references Jira Issue OCPBUGS-60568, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member

hongkailiu commented Nov 27, 2025

/testwith openshift/cluster-kube-controller-manager-operator/main/e2e-aws-ovn-upgrade openshift/cluster-version-operator#1264

@lance5890 lance5890 force-pushed the remove_automountServiceAccountToken branch from 567046c to 11a525b Compare November 28, 2025 01:10
@lance5890
Copy link
Contributor Author

lance5890 commented Nov 28, 2025

/unhold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

@lance5890: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 11a525b link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hongkailiu
Copy link
Member

hongkailiu commented Nov 28, 2025

/testwith openshift/cluster-kube-controller-manager-operator/main/e2e-aws-ovn-upgrade openshift/cluster-version-operator#1264

@hongkailiu
Copy link
Member

hongkailiu commented Nov 28, 2025

Nice. The job is green. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atiratree atiratree Awaiting requested review from atiratree

@deads2k deads2k Awaiting requested review from deads2k

Assignees

No one assigned

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lance5890 @openshift-ci-robot @tchap @hongkailiu