Skip to content

OCPBUGS-55896: Refactor Kebab+ActionsMenu to use PF #15028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

OCPBUGS-55896: Refactor Kebab+ActionsMenu to use PF #15028

merged 1 commit into from
May 13, 2025
+209 −421

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented May 7, 2025

after:

image
image

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 7, 2025
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-55896, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

after:

image
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. component/topology Related to topology labels May 7, 2025
@logonoff
Copy link
Member Author

logonoff commented May 7, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 7, 2025
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-55896, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei May 7, 2025 15:26
rhamilto
rhamilto reviewed May 7, 2025
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. Excellent work. One question about a CSS rule.

frontend/public/components/utils/_kebab.scss
transform: translateY(-50%);
}
}
.oc-kebab__icon {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still referenced in kebab.tsx.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

frontend/public/components/utils/kebab.tsx
@@ -50,9 +52,10 @@ import {
RouteModel,
VolumeSnapshotModel,
} from '../../models';
import { ContextSubMenuItem } from '@patternfly/react-topology';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@logonoff logonoff force-pushed the OCPBUGS-55896-actions branch 2 times, most recently from fdfcbc6 to 3f5feb3 Compare May 7, 2025 18:38
@logonoff logonoff requested a review from rhamilto May 7, 2025 18:59
@logonoff logonoff force-pushed the OCPBUGS-55896-actions branch from 3f5feb3 to 547537e Compare May 7, 2025 19:12
@rhamilto
Copy link
Member

rhamilto commented May 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f6d63b5 and 2 for PR HEAD 547537e in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f6d63b5 and 2 for PR HEAD 547537e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5e92c19 and 1 for PR HEAD 547537e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3bb267d and 0 for PR HEAD 547537e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2c507cc and 2 for PR HEAD 547537e in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2c507cc and 2 for PR HEAD 547537e in total

@logonoff
Copy link
Member Author

logonoff commented May 8, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d5d1d1c and 1 for PR HEAD 547537e in total

@logonoff
Copy link
Member Author

logonoff commented May 9, 2025

/retest

@logonoff
Copy link
Member Author

logonoff commented May 9, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2025
@logonoff logonoff force-pushed the OCPBUGS-55896-actions branch from 547537e to 32f394e Compare May 9, 2025 19:24
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 9, 2025
@logonoff
Copy link
Member Author

logonoff commented May 9, 2025

/unhold

was missing a data-test-id.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2025
@rhamilto
Copy link
Member

rhamilto commented May 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0657e40 and 2 for PR HEAD 32f394e in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0657e40 and 2 for PR HEAD 32f394e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c34a56d and 1 for PR HEAD 32f394e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c34a56d and 2 for PR HEAD 32f394e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5f50f62 and 2 for PR HEAD 32f394e in total

@logonoff logonoff force-pushed the OCPBUGS-55896-actions branch from 32f394e to ba2e273 Compare May 13, 2025 18:09
@openshift-ci openshift-ci bot added kind/cypress Related to Cypress e2e integration testing and removed lgtm Indicates that a PR is ready to be merged. labels May 13, 2025
@rhamilto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5f50f62 and 2 for PR HEAD ba2e273 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 13, 2025 •
edited
Loading

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-deps e8bc0d2 link true /test verify-deps

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 6a35cad into openshift:main May 13, 2025
7 checks passed
@openshift-ci-robot
Copy link
Contributor

@logonoff: Jira Issue OCPBUGS-55896: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55896 has been moved to the MODIFIED state.

In response to this:

after:

image
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff deleted the OCPBUGS-55896-actions branch May 13, 2025 23:21
@logonoff
Copy link
Member Author

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

@logonoff: new pull request created: #15051

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov

@lokanandaprabhu lokanandaprabhu Awaiting requested review from lokanandaprabhu

@yapei yapei Awaiting requested review from yapei

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/pipelines Related to pipelines-plugin component/topology Related to topology jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@logonoff @openshift-ci-robot @rhamilto @openshift-cherrypick-robot