Skip to content

OCPBUGS-55806: fix bug where AlertItem is missing info icon #15052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 20, 2025
Merged

OCPBUGS-55806: fix bug where AlertItem is missing info icon #15052

openshift-merge-bot merged 1 commit into from
May 20, 2025

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented May 14, 2025 •
edited
Loading

After

Screenshot 2025-05-14 at 9 22 06 AM

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2025

@rhamilto: This pull request references Jira Issue OCPBUGS-55806, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2025

@rhamilto: This pull request references Jira Issue OCPBUGS-55806, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

After

Screenshot 2025-05-14 at 9 22 06 AM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei May 14, 2025 13:38
@rhamilto
Copy link
Member Author

rhamilto commented May 14, 2025

/cherrypick release-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 14, 2025

@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from kyoto and spadgett May 14, 2025 13:42
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels May 14, 2025
TheRealJon
TheRealJon approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2025

/retest-required

Remaining retests: 0 against base HEAD 1d84d82 and 2 for PR HEAD e2ffbe31686efbb43e9a8561e78a9d31534115fc in total

@rhamilto
Copy link
Member Author

rhamilto commented May 14, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2025

/retest-required

Remaining retests: 0 against base HEAD 6f22825 and 1 for PR HEAD e2ffbe31686efbb43e9a8561e78a9d31534115fc in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 15, 2025

/retest-required

Remaining retests: 0 against base HEAD 6f22825 and 2 for PR HEAD e2ffbe31686efbb43e9a8561e78a9d31534115fc in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 15, 2025

/retest-required

Remaining retests: 0 against base HEAD 6f22825 and 2 for PR HEAD e2ffbe31686efbb43e9a8561e78a9d31534115fc in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
@rhamilto
Copy link
Member Author

rhamilto commented May 15, 2025

@TheRealJon, mind re-tagging? Had to regenerate i18n JSON.

@rhamilto
Copy link
Member Author

rhamilto commented May 15, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented May 15, 2025

/test e2e-gcp-console

1 similar comment
@rhamilto
Copy link
Member Author

rhamilto commented May 16, 2025

/test e2e-gcp-console

@rhamilto
Copy link
Member Author

rhamilto commented May 16, 2025

/test e2e-gcp-console

logonoff
logonoff approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2025

/retest-required

Remaining retests: 0 against base HEAD 5e5782a and 2 for PR HEAD e9bdf09 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 17, 2025

/retest-required

Remaining retests: 0 against base HEAD 0556a3e and 1 for PR HEAD e9bdf09 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 17, 2025

/retest-required

Remaining retests: 0 against base HEAD 0556a3e and 2 for PR HEAD e9bdf09 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 17, 2025

/retest-required

Remaining retests: 0 against base HEAD 98a37b9 and 1 for PR HEAD e9bdf09 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 19, 2025

/retest-required

Remaining retests: 0 against base HEAD 98a37b9 and 2 for PR HEAD e9bdf09 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 970d12e into openshift:main May 20, 2025
6 of 7 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 20, 2025

@rhamilto: Jira Issue OCPBUGS-55806: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55806 has been moved to the MODIFIED state.

In response to this:

After

Screenshot 2025-05-14 at 9 22 06 AM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 20, 2025

@rhamilto: new pull request created: #15071

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 20, 2025
Merged
@rhamilto rhamilto deleted the OCPBUGS-55806 branch May 27, 2025 12:30
yapei pushed a commit to yapei/console that referenced this pull request Jul 11, 2025
@openshift-merge-bot
Merge pull request openshift#15052 from rhamilto/OCPBUGS-55806
49acf97 
OCPBUGS-55806: fix bug where AlertItem is missing info icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

@yapei yapei Awaiting requested review from yapei

@kyoto kyoto Awaiting requested review from kyoto

@spadgett spadgett Awaiting requested review from spadgett

+1 more reviewer

@logonoff logonoff logonoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@logonoff logonoff

@TheRealJon TheRealJon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @openshift-cherrypick-robot @logonoff @TheRealJon