-
Notifications
You must be signed in to change notification settings - Fork 637
fix : [WTO-332] Sanitize sensitive information from URLs in terminal output #15053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohanKanojia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @rohanKanojia. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e40dd70
to
56b320c
Compare
/ok-to-test |
Sanitize sensitive information from URLs like proxy crdentials before printing them to web terminal console. Signed-off-by: Rohan Kumar <[email protected]>
56b320c
to
9d1c031
Compare
/ok-to-test |
8597012
to
f2393b6
Compare
Instead of replacing all URLs, just replace Proxy URLs in command output. First extract the URL values from Pod spec then perform search/replace Signed-off-by: Rohan Kumar <[email protected]>
f2393b6
to
a558ea3
Compare
/ok-to-test |
@rohanKanojia: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Related to https://issues.redhat.com/browse/WTO-332
When user is using Web Terminal in proxy environment, and prints environment variables, proxy credentials are visible:
Sanitize sensitive information from URLs like proxy credentials before printing them to the web terminal console.
Before this change
behavior on OpenShift 4.18 cluster created via cluster bot

After this change
Reloading console deployment with

quay.io/rokumar/console:latest