OCPBUGS-56087: Opening Edit Secret modal and saving without changes throws error #15058
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@Mylanos: This pull request references Jira Issue OCPBUGS-56087, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Mylanos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@Mylanos: This pull request references Jira Issue OCPBUGS-56087, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Mylanos
changed the title
|
@Mylanos: This pull request references Jira Issue OCPBUGS-56087, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| }), | ||
| acc[key] = value ? Base64.decode(value) : ''; | ||
| return acc; | ||
| }, {} as { [key: string]: string }), |
There was a problem hiding this comment.
Nit - you can avoid accumulator type as cast like so
Object.entries<Record<string, string>>( ... )
previously when you tried to edit a Secret with binary data, the string data was initialized with a keypair with null value instead of an empty object, which resulted in errors when saving the secret without changes. After those changes we omit keypairs that have binary values.
Mylanos
force-pushed
the
open-edit-secret-modal-no-change-error
branch
from
3e2a80d to
154c422
Compare
|
@Mylanos: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
restructure initialization of
stringDatapreviously when you tried to edit a Secret with binary data, the
stringDatawas initialized to be a key pair with null value instead of being an empty object, which resulted in errors when saving the secret without changes. After those changes we omit key pairs that have binary values from thestringData.after:
Screen.Recording.2025-05-16.at.16.29.29.mov