Skip to content

no-jira: Machine Api Operator GCP must search for the GCP Custom Endpoints Installer feature gate #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

no-jira: Machine Api Operator GCP must search for the GCP Custom Endpoints Installer feature gate #128

merged 2 commits into from
Sep 11, 2025

Conversation

barbacbd
Copy link
Contributor

Update the reference from FeatureGateGCPCustomAPIEndpoints to FeatureGateGCPCustomAPIEndpointsInstall due to new procedures. This indicates that the feature gate originates as an OpenShift installer feature gate.

@barbacbd
no-jira: Update GCP Custom Endpoints Feature Gate reference
3fb47f6 
** go.mod and go.sum updates.
** Vendor Updates.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 27, 2025
@openshift-ci-robot
Copy link
Contributor

@barbacbd: This pull request explicitly references no jira issue.

In response to this:

Update the reference from FeatureGateGCPCustomAPIEndpoints to FeatureGateGCPCustomAPIEndpointsInstall due to new procedures. This indicates that the feature gate originates as an OpenShift installer feature gate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mdbooth and racheljpg August 27, 2025 19:02
@barbacbd
Copy link
Contributor Author

/retest-required

1 similar comment
@barbacbd
Copy link
Contributor Author

/retest-required

@damdo
Copy link
Member

damdo commented Aug 29, 2025

/retest

damdo
damdo reviewed Aug 29, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Happy to approve this

@barbacbd anyone from your team that has context on this and can drop an LGTM, ty

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2025
@damdo
Copy link
Member

damdo commented Aug 29, 2025

/retest

2 similar comments
@damdo
Copy link
Member

damdo commented Sep 5, 2025

/retest

@damdo
Copy link
Member

damdo commented Sep 5, 2025

/retest

@patrickdillon
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
@damdo
Copy link
Member

damdo commented Sep 8, 2025

/assign @sunzhaohua2 @huali9 @miyadav

Are we happy with the regressions and to put the verified label?

@sunzhaohua2
Copy link

Are we happy with the regressions and to put the verified label?

All gcp cluster installations failed, some operators degrade. machine-controller show panic panic: feature \"GCPCustomAPIEndpointsInstall\" is not registered in FeatureGate

@patrickdillon
Copy link

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
@barbacbd barbacbd requested a review from damdo September 9, 2025 19:00
@damdo
Copy link
Member

damdo commented Sep 10, 2025

You probably need to change this:

machine-api-provider-gcp/cmd/manager/main.go

Line 93 in 0151588

gateOpts, err := features.NewFeatureGateOptions(defaultMutableGate, apifeatures.SelfManaged, apifeatures.FeatureGateMachineAPIMigration, apifeatures.FeatureGateGCPCustomAPIEndpoints)

and any other potential occurrences too

@barbacbd
cloud/gcp/actuators/machine:
f4bf1e2 
** Update the references from FeatureGateGCPCustomAPIEndpoints to FeatureGateGCPCustomAPIEndpointsInstall due to new
procedures. This inidcates that the feature gate originates as an openshift installer feature gate.

cloud/gcp/actuators/machineset:

** Update the references from FeatureGateGCPCustomAPIEndpoints to FeatureGateGCPCustomAPIEndpointsInstall due to new
procedures. This inidcates that the feature gate originates as an openshift installer feature gate.
@barbacbd barbacbd force-pushed the gcp-custom-endpoints-feature-gate-update branch from 7357af1 to f4bf1e2 Compare September 10, 2025 13:03
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/regression-clusterinfra-gcp-ipi-mapi f4bf1e2 link false /test regression-clusterinfra-gcp-ipi-mapi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sunzhaohua2
Copy link

/verified by @sunzhaohua2

Tried day2 enable featuregate GCPCustomAPIEndpointsInstall, cluster looks good.

  customNoUpgrade:
    enabled:
    - GCPCustomAPIEndpointsInstall
  featureSet: CustomNoUpgrade

Fix the regression run failed cases in pr https://github.com/openshift/openshift-tests-private/pull/27161

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 11, 2025
@openshift-ci-robot
Copy link
Contributor

@sunzhaohua2: This PR has been marked as verified by @sunzhaohua2.

In response to this:

/verified by @sunzhaohua2

Tried day2 enable featuregate GCPCustomAPIEndpointsInstall, cluster looks good.

 customNoUpgrade:
   enabled:
   - GCPCustomAPIEndpointsInstall
 featureSet: CustomNoUpgrade

Fix the regression run failed cases in pr https://github.com/openshift/openshift-tests-private/pull/27161

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu
Copy link

sadasu commented Sep 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 55e308a into openshift:main Sep 11, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbooth mdbooth Awaiting requested review from mdbooth

@racheljpg racheljpg Awaiting requested review from racheljpg

@damdo damdo Awaiting requested review from damdo

Assignees

@sadasu sadasu

@patrickdillon patrickdillon

@sunzhaohua2 sunzhaohua2

@miyadav miyadav

@huali9 huali9

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@barbacbd @openshift-ci-robot @damdo @patrickdillon @sunzhaohua2 @sadasu @miyadav @huali9