Skip to content

Conversation

umohnani8
Copy link
Contributor

Closes https://issues.redhat.com/browse/OCPBUGS-61114

- What I did
After an image was built and rolled out successfully, and we triggered a new build, the ImageBuildDegraded status wasn't updating correctly as it kept focusing on the successful build and not the build currently active. Fix the logic to be able to keep track of the active build instead and update the status accordingly.

- How to verify it

  1. Create an MOSC that succeeds
  2. After the build is successful and rolled out, edit the MOSC
  3. Ensure the ImageBuildDegraded status option is following the active build and updating correctly

- Description for the changelog
ImageBuildDegraded status option should correctly update by following the status of the active build.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 8, 2025
@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request references Jira Issue OCPBUGS-61114, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Closes https://issues.redhat.com/browse/OCPBUGS-61114

- What I did
After an image was built and rolled out successfully, and we triggered a new build, the ImageBuildDegraded status wasn't updating correctly as it kept focusing on the successful build and not the build currently active. Fix the logic to be able to keep track of the active build instead and update the status accordingly.

- How to verify it

  1. Create an MOSC that succeeds
  2. After the build is successful and rolled out, edit the MOSC
  3. Ensure the ImageBuildDegraded status option is following the active build and updating correctly

- Description for the changelog
ImageBuildDegraded status option should correctly update by following the status of the active build.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2025
@umohnani8
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 8, 2025
@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request references Jira Issue OCPBUGS-61114, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr September 8, 2025 17:28
After an image was built and rolled out successfully,
and we triggered a new build, the ImageBuildDegraded
status wasn't updating correctly as it kept focusing on
the successful build and not the build currently active.
Fix the logic to be able to keep track of the active
build instead and update the status accordingly.

Signed-off-by: Urvashi <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

@umohnani8: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-single-node ae88523 link true /test e2e-gcp-op-single-node
ci/prow/e2e-gcp-op-1of2 ae88523 link true /test e2e-gcp-op-1of2
ci/prow/e2e-aws-mco-disruptive ae88523 link false /test e2e-aws-mco-disruptive
ci/prow/e2e-gcp-mco-disruptive ae88523 link false /test e2e-gcp-mco-disruptive
ci/prow/e2e-aws-ovn-windows ae88523 link false /test e2e-aws-ovn-windows
ci/prow/e2e-azure-ovn-upgrade-out-of-change ae88523 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl ae88523 link false /test e2e-gcp-op-ocl
ci/prow/e2e-hypershift ae88523 link true /test e2e-hypershift
ci/prow/bootstrap-unit ae88523 link false /test bootstrap-unit
ci/prow/verify ae88523 link true /test verify
ci/prow/e2e-agent-compact-ipv4 ae88523 link false /test e2e-agent-compact-ipv4
ci/prow/unit ae88523 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants