[release-4.18] OCPBUGS-62294: Make static DNS with DHCP IP work #5311
Conversation
Currently the only supported combination is either DHCP or static IP on the default gateway interface. This leads to the scenario when IP address from DHCP and static DNS address is not working (the custom DNS is just ignored). With this change we allow to have DNS configured manually no matter where the IP address of the interface comes from. In principle this should be done using k-nmstate operator and its global DNS configuration, but it seems there are scenarios where we want this functionality already at installation time. Closes: OCPBUGS-44732 (cherry picked from commit 0d86d9c)
nmcli --get-values will escape `:` and `\` by default.
This is because `:` is the normal key:value separator.
This escape breaks IPv6 output and MAC address output.
`src/nmcli/utils.c`
```c
if (nmc_config->print_output == NMC_PRINT_TERSE) {
if (nmc_config->escape_values) {
const char *p = text;
while (*p) {
if (*p == ':' || *p == '\\')
g_string_append_c(str, '\\'); /* Escaping by '\' */
g_string_append_c(str, *p);
p++;
}
} else
```
(cherry picked from commit 15e7e5e)
openshift-ci-robot
added
jira/valid-reference
|
@cybertron: This pull request references Jira Issue OCPBUGS-62294, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
requested review from
rbbratta,
dkhater-redhat and
yuqi-zhang
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cybertron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @rbbratta |
openshift-ci-robot
added
the
verified
|
@rbbratta: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is a combined backport of #5106 and #4724 as both PRs were needed to make this work in all circumstances.