[WIP] Implement install time support for Image Mode #5318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
umohnani8
force-pushed
the
reboots
branch
9 times, most recently
from
bb4ef32 to
a391d17
Compare
Add install time support for Image Mode by using a pre-built custom OS container image with the MachineOSConfig CR created at install time in the manifests directory. **Core Seeding Implementation for Pre-built Container Image:** - Added annotation-driven seeding detection in addMachineOSConfig() - Implemented seedMachineOSConfigWithExistingImage() for complete seeding workflow - Added createSyntheticMachineOSBuild() to generate "successful" builds for pre-built images - Added updateMachineOSConfigForSeeding() to update status and annotations **Bootstrap Integration:** - Added MachineOSConfig recognition in bootstrap processing - Implemented syncMachineOSConfigs() in operator for post-bootstrap processing - Creates /etc/mcs/bootstrap/machine-os-configs/ directory structure - Processes MachineOSConfig manifests during cluster startup **Constants and Configuration:** - Added PreBuiltImageAnnotationKey constant for annotation-driven behavior - Added bootstrap integration constants and paths - Enhanced build controller with seeding detection logic **Testing Infrastructure:** - Added comprehensive unit tests for seeding workflow - TestCreateSyntheticMachineOSBuild validates synthetic build creation - TestAddMachineOSConfigRouting tests annotation detection - TestAddMachineOSConfigSeeding tests seeding decision logic - Added bootstrap test validation with layered-worker example manifest **Key Features:** - Maintains 100% backward compatibility with existing MachineOSConfig objects - Routes annotated configs to seeding workflow, non-annotated to normal OCL - Creates proper metadata, labels, and object references expected by MCO - Enables seamless integration with existing controller logic **Technical Details:** - Uses PreBuiltImageAnnotationKey annotation to trigger seeding behavior - Validates image format (digest format @sha256: required) - Creates synthetic MachineOSBuild objects with success status - Updates MachineOSConfig status with CurrentImagePullSpec for MCD consumption - Uses PreBuiltImageLabelKey label to keep track of MOSB created by pre-built container image - Integrates with existing sync pipeline and bootstrap completion detection Signed-off-by: Urvashi <[email protected]>
Signed-off-by: Urvashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add install time support for Image Mode by using a pre-built custom OS container image with the MachineOSConfig CR created at install time in the manifests directory.
Core Seeding Implementation for Pre-built Container Image:
Bootstrap Integration:
Constants and Configuration:
Testing Infrastructure:
Key Features:
Technical Details:
- What I did
- How to verify it
- Description for the changelog