-
Notifications
You must be signed in to change notification settings - Fork 448
OCPBUGS-62670: [release-4.19] Networking: reset ovn-remote config and allow ovnkube controller to set it #5324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.19
Are you sure you want to change the base?
Conversation
…et it This fixes the issue where ovn-remote is set prior to reboot and when boot occurs, ovn-controller syncs quickly with a stale SB DB. This PR is part of the EIP GARP issue fix. Its required because when ovnkube-controller and ovn-controller container start on boot, there is no order to which container will start first, and we dont want ovn-controller to connect to SB DB before ovnkube controller has added the drop flows. Ideally, we would only allow ovn-controller to sync with SB DB when ovnkube controller has concluded syncing and the changes are available in SB DB. That maybe future work. Signed-off-by: Martin Kennelly <[email protected]> (cherry picked from commit 567a191)
@martinkennelly: This pull request references Jira Issue OCPBUGS-62670, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/payload-with-prs 4.19 nightly blocking openshift/cluster-network-operator#2809 openshift/ovn-kubernetes#2774 |
@martinkennelly: trigger 11 job(s) of type blocking for the nightly release of OCP 4.19
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a89d3170-9f8b-11f0-93fd-ee70f1d60e20-0 |
@martinkennelly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@yuqi-zhang Thank you for reviewing the 4.20 PR - its not merged but we want the approvers lined up and labels added. Its a critical bug and we have the fastfix label applied. We will only merge when QE has verified. Its a clean cherry-pick. |
/approve The only thing I'd like to add is that currently the manual bugs for 4.19 and 4.18 has weird cloning, and I think prow expects a clone of the previous version (so in the clone links, the depends on should be the 4.20 bug and not the 4.18 bug) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinkennelly, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…et it
This fixes the issue where ovn-remote is set
prior to reboot and when boot occurs, ovn-controller syncs quickly with a stale SB DB.
This PR is part of the EIP GARP issue fix.
Its required because when ovnkube-controller and
ovn-controller container start on boot, there
is no order to which container will start first,
and we dont want ovn-controller to connect to SB DB before ovnkube controller has added the drop flows.
Ideally, we would only allow ovn-controller to sync with SB DB when ovnkube controller has concluded
syncing and the changes are available in SB DB.
That maybe future work.
(cherry picked from commit 567a191)
/hold
Depends on #5317