OCPBUGS-63154: [release-4.17] Networking: reset ovn-remote config and allow ovnkube controller to set it #5358
Conversation
…et it This fixes the issue where ovn-remote is set prior to reboot and when boot occurs, ovn-controller syncs quickly with a stale SB DB. This PR is part of the EIP GARP issue fix. Its required because when ovnkube-controller and ovn-controller container start on boot, there is no order to which container will start first, and we dont want ovn-controller to connect to SB DB before ovnkube controller has added the drop flows. Ideally, we would only allow ovn-controller to sync with SB DB when ovnkube controller has concluded syncing and the changes are available in SB DB. That maybe future work. Signed-off-by: Martin Kennelly <[email protected]> (cherry picked from commit 567a191) (cherry picked from commit 98291f7) (cherry picked from commit ca678bd)
openshift-ci-robot
added
jira/severity-important
openshift-ci
bot
added
the
do-not-merge/hold
|
@martinkennelly: This pull request references Jira Issue OCPBUGS-63154, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: martinkennelly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-with-prs 4.17 ci blocking openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: trigger 4 job(s) of type blocking for the ci release of OCP 4.17
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9edb31f0-aa7b-11f0-9c89-1e6f781e075b-0 |
|
/payload-with-prs 4.17 nightly blocking openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: trigger 8 job(s) of type blocking for the nightly release of OCP 4.17
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b42b47c0-aa7b-11f0-800b-f0a8e74790a8-0 |
Saw many build errors because unable to pull an image. Unrelated to my PRs.: |
|
/payload-with-prs 4.17 nightly blocking openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: trigger 8 job(s) of type blocking for the nightly release of OCP 4.17
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0098b1c0-aaa8-11f0-8214-eeb08d09becf-0 |
|
/retest Known issue today. Discussed on test platforum. Should be resolved now. |
|
/payload-with-prs 4.17 ci blocking openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 Same image pull issue with last run |
|
@martinkennelly: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
unable to get additional pr info from string: pull: string: pull doesn't match expected format: org/repo#number
Please contact an administrator to resolve this issue. |
|
/payload-with-prs 4.17 ci blocking openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: trigger 4 job(s) of type blocking for the ci release of OCP 4.17
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/415df670-aaa8-11f0-9746-b80293902535-0 |
|
/test e2e-gcp-op Unrelated UT flake: |
|
/test e2e-hypershift cluster init failure - unrelated. Bad day for Hypershift yesterday. |
|
/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9a3d6070-ab37-11f0-9e94-db54b8692762-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: given command is invalid: at least one of the commands given is only supported on a one-command-per-comment basis, please separate out commands as multiple comments |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ec788e00-ab37-11f0-9d91-c753c0c5439c-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f6b4cb40-ab37-11f0-8bc3-e0a4a264d89b-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-upgrade openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fe626e60-ab37-11f0-940f-5851f796847f-0 |
|
/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/04b08180-ab38-11f0-804b-dbfc4243f7b3-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-bm openshift/cluster-network-operator#2818 openshift/ovn-kubernetes#2807 |
|
@martinkennelly: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0b473660-ab38-11f0-867c-fad12314f178-0 |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@martinkennelly: This pull request references Jira Issue OCPBUGS-63154, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/verified by 'pre-merge testing' |
openshift-ci-robot
added
the
verified
|
@jechen0648: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-hypershift |
|
@martinkennelly: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
…et it
This fixes the issue where ovn-remote is set
prior to reboot and when boot occurs, ovn-controller syncs quickly with a stale SB DB.
This PR is part of the EIP GARP issue fix.
Its required because when ovnkube-controller and
ovn-controller container start on boot, there
is no order to which container will start first,
and we dont want ovn-controller to connect to SB DB before ovnkube controller has added the drop flows.
Ideally, we would only allow ovn-controller to sync with SB DB when ovnkube controller has concluded
syncing and the changes are available in SB DB.
That maybe future work.
(cherry picked from commit 567a191) (cherry picked from commit 98291f7) (cherry picked from commit ca678bd)
Depends on #5325
/hold