-
Notifications
You must be signed in to change notification settings - Fork 457
OCPNODE-3719: Default Enablement of Auto Sizing Reserved in OpenShift 4.21 #5390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OCPNODE-3719: Default Enablement of Auto Sizing Reserved in OpenShift 4.21 #5390
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ngopalak-redhat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8b9e810 to
4ff1f91
Compare
|
@ngopalak-redhat: This pull request references OCPNODE-3719 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ngopalak-redhat: This pull request references OCPNODE-3719 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test all |
|
/hold Wait for openshift/cincinnati-graph-data#8277 to merge |
|
@haircommander @sairameshv Please review. I have kept it on hold so that the 4.20 and the cincinnati change can merge |
|
@ngopalak-redhat: This pull request references OCPNODE-3719 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test e2e-hypershift |
|
/retest-required |
2658574 to
a3b1c01
Compare
|
@sairameshv I made the changes and retested setting system reserved manually. When system reserved is set via a kubelet config the auto-sizing-reserved is set to false as expected. Test Result
|
|
@ngopalak-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes #OCPNODE-3719
- What I did
This PR updates the default cluster configuration to enable Auto Sizing Reserved for all new OpenShift clusters created from version 4.21 onward.
New Cluster Default: New 4.21 clusters will now have Auto Sizing Reserved enabled by default
Upgrade Preservation:
Clusters originally created before 4.21 will not be impacted by this default change. The prior behavior (disabled) is maintained unless one of the following occurs:
If a user defines explicit memory or cpu reservations within a custom KubeletConfig, Auto Sizing Reserved will automatically remain disabled to prevent conflicting configuration logic.
Related 4.20 Patch: For context on how older clusters are transitioned, please refer to the pre-requisite patch:
- How to verify it
The following scenarios were successfully validated:Upgrade Test (4.20 --> 4.21 + PR): A cluster created in 4.20 was upgraded to this 4.21 PR. Auto Sizing Reserved was confirmed to be disabled, preserving the pre-4.21 behavior.
New Cluster Test (4.21 + PR): A new cluster was provisioned in 4.21 with this PR. Auto Sizing Reserved was confirmed to be enabled by default.
Manual Test result
Here's the state of mc after upgrade from [4.20 + patch] to [4.21 + this pr]:
We can see "auto-sizing-disabled" mc
Here's the post upgrade NODE_SIZING_ENABLED:
Here are the nodes post upgrade, showing successful upgrade:
Now I can apply kubeletconfig to enable auto sizing reserved:
After applying the NODE_SIZING_ENABLED changes:
Also we can see the KubeletConfig showing correct auto sizing reserved:
- Description for the changelog
Enable auto sizing reserved by default on new clusters