OTA-1010: extract included manifests with net-new capabilities #1958

hongkailiu · 2025-01-14T01:06:00Z

Before this pull, we enabled three 3 net-new capabilities for 4.13 clusters:

oc/pkg/cli/admin/release/extract_tools.go

Lines 1241 to 1252 in e005223

    
           // FIXME: eventually pull in GetImplicitlyEnabledCapabilities from https://github.com/openshift/cluster-version-operator/blob/86e24d66119a73f50282b66a8d6f2e3518aa0e15/pkg/payload/payload.go#L237-L240 for cases where a minor update would implicitly enable some additional capabilities.  For now, 4.13 to 4.14 will always enable MachineAPI, ImageRegistry, etc.. 
        
           currentVersion := clusterVersion.Status.Desired.Version 
        
           matches := regexp.MustCompile(`^(\d+[.]\d+)[.].*`).FindStringSubmatch(currentVersion) 
        
           if len(matches) < 2 { 
        
           	return config, fmt.Errorf("failed to parse major.minor version from ClusterVersion status.desired.version %q", currentVersion) 
        
           } else if matches[1] == "4.13" { 
        
           	build := configv1.ClusterVersionCapability("Build") 
        
           	deploymentConfig := configv1.ClusterVersionCapability("DeploymentConfig") 
        
           	imageRegistry := configv1.ClusterVersionCapability("ImageRegistry") 
        
           	config.Capabilities.EnabledCapabilities = append(config.Capabilities.EnabledCapabilities, configv1.ClusterVersionCapabilityMachineAPI, build, deploymentConfig, imageRegistry) 
        
           	config.Capabilities.KnownCapabilities = append(config.Capabilities.KnownCapabilities, configv1.ClusterVersionCapabilityMachineAPI, build, deploymentConfig, imageRegistry) 
        
           }

Now the capabilities for the incoming release is calculated with the function from CVO based on the manifests from the current release and the ones from the incoming release.

To fit the current code that had TarEntryCallback already, the above logic is implemented via a ManifestReceiver that works between the upstream TarEntryCallback and the downstream manifestsCallback. With needEnabledCapabilities, it tells the receiver that the manifestsCallback is called with enabled capabilities computed. The price is that manifestsCallback is called only after it collects all the manifests from the upstream.

openshift-ci-robot · 2025-01-14T01:06:03Z

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-01-14T01:06:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/cli/admin/release/extract_tools.go

openshift-ci-robot · 2025-01-14T12:11:06Z

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This pull adds a ManifestReceiver that works between the upstream TarEntryCallback and the downstream manifestsCallback. With needEnabledCapabilities, it tells the receiver that the manifestsCallback is called with enabled capabilities computed. The price is that manifestsCallback is called only after it collects all the manifests from the upstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-01-14T12:27:12Z

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Before this pull, we enabled three 3 net-new capabilities for 4.13 clusters:

oc/pkg/cli/admin/release/extract_tools.go

Lines 1241 to 1252 in e005223

// FIXME: eventually pull in GetImplicitlyEnabledCapabilities from https://github.com/openshift/cluster-version-operator/blob/86e24d66119a73f50282b66a8d6f2e3518aa0e15/pkg/payload/payload.go#L237-L240 for cases where a minor update would implicitly enable some additional capabilities. For now, 4.13 to 4.14 will always enable MachineAPI, ImageRegistry, etc..

currentVersion := clusterVersion.Status.Desired.Version

matches := regexp.MustCompile(`^(\d+[.]\d+)[.].*`).FindStringSubmatch(currentVersion)

if len(matches) < 2 {

return config, fmt.Errorf("failed to parse major.minor version from ClusterVersion status.desired.version %q", currentVersion)

} else if matches[1] == "4.13" {

build := configv1.ClusterVersionCapability("Build")

deploymentConfig := configv1.ClusterVersionCapability("DeploymentConfig")

imageRegistry := configv1.ClusterVersionCapability("ImageRegistry")

config.Capabilities.EnabledCapabilities = append(config.Capabilities.EnabledCapabilities, configv1.ClusterVersionCapabilityMachineAPI, build, deploymentConfig, imageRegistry)

config.Capabilities.KnownCapabilities = append(config.Capabilities.KnownCapabilities, configv1.ClusterVersionCapabilityMachineAPI, build, deploymentConfig, imageRegistry)

}

Now the capabilities for the incoming release is calculated with the function from CVO based on the manifests from the current release and the ones from the incoming release.

To fit the current code that had TarEntryCallback already, the above logic is implemented via a ManifestReceiver that works between the upstream TarEntryCallback and the downstream manifestsCallback. With needEnabledCapabilities, it tells the receiver that the manifestsCallback is called with enabled capabilities computed. The price is that manifestsCallback is called only after it collects all the manifests from the upstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

wking · 2025-01-14T13:20:05Z

pkg/cli/admin/release/extract_tools.go

+			manifestInclusionConfiguration.Overrides,
+			true,
+		)
+		// update manifest is enabled, no need to check


hmm, but with IncludeAllowUnknownCapabilities, aren't the ones that fail the ones we can ignore? I'd guess they meant "not even with all these new caps enabled will this manifest get included". The ones we'll implicitly enable caps for are the ones that fail to get included if we apply the current caps, but which do get included if we allow new caps, and which match SameResourceID.

This function is refactored from this one in CVO: https://github.com/openshift/cluster-version-operator/blob/e90705bb5457b2b9d449b4377036c3de6617ebb6/pkg/payload/payload.go#L247-L252

My understanding is very weak on this function (although i have read it a couple of times already).

hmm, but with IncludeAllowUnknownCapabilities, aren't the ones that fail the ones we can ignore?

No. Passed ones (updateManErr == nil in the next line) are ignored. The manifests that are included on the cluster wont generate new implicitly enabled capabilities.

hongkailiu · 2025-01-31T22:09:46Z

/retest-required

petr-muller · 2025-02-14T18:34:31Z

/cc

hongkailiu · 2025-03-04T18:33:43Z

/retest-required

hongkailiu · 2025-03-04T18:42:26Z

Some testing result from 0431ce4 (outdated)

Cluster-bot:

launch 4.13.12 aws

$ make oc
$ ./oc adm release extract --included --credentials-requests --to credentials-requests quay.io/openshift-release-dev/ocp-release:4.14.0-rc.0-x86_64
I0304 13:36:44.744021   32452 extract_tools.go:1254] Those capabilities become implicitly enabled for the incoming release [ImageRegistry MachineAPI]
Extracted release payload from digest sha256:1d2cc38cbd94c532dc822ff793f46b23a93b76b400f7d92b13c1e1da042c88fe created at 2023-09-07T07:37:47Z

$ rg ImageRegistry credentials-requests
credentials-requests/0000_50_cluster-image-registry-operator_01-registry-credentials-request.yaml
6:    capability.openshift.io/name: ImageRegistry

$ ll credentials-requests
total 48
-rw-r--r--@ 1 hongkliu  staff   1.8K Mar  4 13:36 0000_30_machine-api-operator_00_credentials-request.yaml
-rw-r--r--@ 1 hongkliu  staff   738B Mar  4 13:36 0000_50_cloud-credential-operator_05-iam-ro-credentialsrequest.yaml
-rw-r--r--@ 1 hongkliu  staff   1.3K Mar  4 13:36 0000_50_cluster-image-registry-operator_01-registry-credentials-request.yaml
-rw-r--r--@ 1 hongkliu  staff   920B Mar  4 13:36 0000_50_cluster-ingress-operator_00-ingress-credentials-request.yaml
-rw-r--r--@ 1 hongkliu  staff   1.0K Mar  4 13:36 0000_50_cluster-network-operator_02-cncc-credentials.yaml
-rw-r--r--@ 1 hongkliu  staff   1.5K Mar  4 13:36 0000_50_cluster-storage-operator_03_credentials_request_aws.yaml

### without --included
$ rm -rf credentials-requests          
$ ./oc adm release extract --to credentials-requests quay.io/openshift-release-dev/ocp-release:4.14.0-rc.0-x86_64                                  
Extracted release payload from digest sha256:1d2cc38cbd94c532dc822ff793f46b23a93b76b400f7d92b13c1e1da042c88fe created at 2023-09-07T07:37:47Z

$ ll credentials-requests | wc -l
     682

hongkailiu · 2025-03-04T21:10:01Z

/retest-required

hongkailiu · 2025-03-04T21:10:21Z

/test okd-scos-e2e-aws-ovn

hongkailiu · 2025-03-05T13:36:47Z

/test e2e-agnostic-ovn-cmd

petr-muller · 2025-03-11T12:48:01Z

/uncc

I am not paying attention OTA-1010 matter that much b/c afaik Trevor is involved in this, so I uncc myself to avoid giving false impression that I plan to review here. If my review or approval is necessary, feel free to /cc me again.

hongkailiu · 2025-03-14T06:02:05Z

pkg/cli/admin/release/extract_tools.go

+			capSet = capabilitiesSpec.BaselineCapabilitySet
+		}
+		deepCopy := clusterVersion.Status.Capabilities.DeepCopy()
+		if capSet == configv1.ClusterVersionCapabilitySetCurrent {


v4.y could be grow too over time.
But it keeps the consistency with

oc/pkg/cli/admin/release/extract_tools.go

Lines 1300 to 1302 in def90a6

if data.Capabilities.BaselineCapabilitySet == configv1.ClusterVersionCapabilitySetCurrent {

klog.Infof("If the eventual cluster will not be the same minor version as this %s 'oc', the actual %s capability set may differ.", reportedVersion, data.Capabilities.BaselineCapabilitySet)

}

hongkailiu · 2025-03-17T14:15:59Z

Rerun the test with def90a6:

launch 4.13.12 aws

The cluster did not set BASELINE_CAPABILITY_SET. So it is the default value vCurrent.

$ oc get clusterversions.config.openshift.io version -o yaml | yq .spec
{
  "channel": "candidate-4.13",
  "clusterID": "01541c49-a5d6-4b02-ba6a-161a12c3ca79",
  "upstream": "https://api.integration.openshift.com/api/upgrades_info/graph"
}

$ ./oc adm release extract --included --credentials-requests --to credentials-requests quay.io/openshift-release-dev/ocp-release:4.14.0-rc.0-x86_64

I0314 09:39:57.809034   23241 extract_tools.go:1340] If the eventual cluster will not be the same minor version as this v4.2.0-alpha.0-2583-gdef90a6 'oc', the actual vCurrent capability set may differ.
I0314 09:39:57.809062   23241 extract_tools.go:1343] If the eventual cluster will not be the same minor version as this v4.2.0-alpha.0-2583-gdef90a6 'oc', the known capability sets may differ.
I0314 09:40:11.867239   23241 extract_tools.go:1253] Those capabilities become implicitly enabled for the incoming release []
Extracted release payload from digest sha256:1d2cc38cbd94c532dc822ff793f46b23a93b76b400f7d92b13c1e1da042c88fe created at 2023-09-07T07:37:47Z

$ rg ImageRegistry credentials-requests
credentials-requests/0000_50_cluster-image-registry-operator_01-registry-credentials-request.yaml
6:    capability.openshift.io/name: ImageRegistry

$ ll credentials-requests
total 48
-rw-r--r--@ 1 hongkliu  staff   1.8K Mar 14 09:40 0000_30_machine-api-operator_00_credentials-request.yaml
-rw-r--r--@ 1 hongkliu  staff   738B Mar 14 09:40 0000_50_cloud-credential-operator_05-iam-ro-credentialsrequest.yaml
-rw-r--r--@ 1 hongkliu  staff   1.3K Mar 14 09:40 0000_50_cluster-image-registry-operator_01-registry-credentials-request.yaml
-rw-r--r--@ 1 hongkliu  staff   920B Mar 14 09:40 0000_50_cluster-ingress-operator_00-ingress-credentials-request.yaml
-rw-r--r--@ 1 hongkliu  staff   1.0K Mar 14 09:40 0000_50_cluster-network-operator_02-cncc-credentials.yaml
-rw-r--r--@ 1 hongkliu  staff   1.5K Mar 14 09:40 0000_50_cluster-storage-operator_03_credentials_request_aws.yaml

Comparing with #1958 (comment), no caps became implicitly enabled as expected. Because they would be (explicitly) enabled with BASELINE_CAPABILITY_SET=vCurrent.

I wanted to try BASELINE_CAPABILITY_SET=None with

launch 4.13.12 aws,no-capabilities

But cluster-bot is not so happy with the command.

I expect to see some implicitly enabled caps there.

Update on May 20.
Thanks to @jiajliu for the magic that creates a 4.13.12 cluster with baselineCapabilitySet=None
Create openshift/release#63030 then trigger the rehearsal by

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-4.14-upgrade-from-stable-4.13-aws-upi-basecap-none-amd-f28

When the rehearsal job came to

INFO[2025-03-20T16:04:13Z] Running step aws-upi-basecap-none-amd-f28-wait.

Then login to the build farm to get the kubeconfig to the ephemeral cluster:

$ oc -n ci-op-76cqklsf extract secret/aws-upi-basecap-none-amd-f28 --to=- --keys kubeconfig > ~/.kube/config

Repeat the above test:

$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.13.12   True        False         34m     Cluster version is 4.13.12

$ oc get clusterversions.config.openshift.io version -o yaml | yq .spec
{
  "capabilities": {
    "baselineCapabilitySet": "None"
  },
  "clusterID": "a6bbd42d-eb66-44b6-89de-ca2be2985fd5"
}

$ ./oc adm release extract --included --credentials-requests --to credentials-requests quay.io/openshift-release-dev/ocp-release:4.14.0-rc.0-x86_64
I0320 12:26:25.194094    7394 extract_tools.go:1343] If the eventual cluster will not be the same minor version as this v4.2.0-alpha.0-2583-gdef90a6 'oc', the known capability sets may differ.
I0320 12:27:04.242248    7394 extract_tools.go:1253] Those capabilities become implicitly enabled for the incoming release [ImageRegistry MachineAPI]
Extracted release payload from digest sha256:1d2cc38cbd94c532dc822ff793f46b23a93b76b400f7d92b13c1e1da042c88fe created at 2023-09-07T07:37:47Z

$ rg ImageRegistry credentials-requests
credentials-requests/0000_50_cluster-image-registry-operator_01-registry-credentials-request.yaml
6:    capability.openshift.io/name: ImageRegistry

The logs look good to me.

hongkailiu · 2025-03-17T14:16:27Z

/test e2e-agnostic-ovn-cmd

openshift-ci · 2025-03-17T14:16:48Z

@hongkailiu: No presubmit jobs available for openshift/oc@master

In response to this:

/test e2e-agnostic-ovn-cmd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hongkailiu · 2025-03-20T20:41:46Z

/retest-required

wking · 2025-03-21T04:00:30Z

pkg/cli/admin/release/extract_tools.go

+			klog.Infof("If the eventual cluster will not be the same minor version as this %s 'oc', the actual %s capability set may differ.", reportedVersion, capSet)
+		}
+		deepCopy.EnabledCapabilities = append(deepCopy.EnabledCapabilities, configv1.ClusterVersionCapabilitySets[capSet]...)
+		klog.Infof("If the eventual cluster will not be the same minor version as this %s 'oc', the known capability sets may differ.", reportedVersion)


nit: this looks like it will be an unnecessary echo in the capSet == configv1.ClusterVersionCapabilitySetCurrent case, where we've just logged a very similar message above. Can we put this log line into an else branch, or something? We may also have a way to figure out the target version from the pullspec we're extracting, and then be able to know instead of guess the if?

Can we put this log line into an else branch, or something?

Done.

We may also have a way to figure out the target version from the pullspec we're extracting

Left a TODO for this.

Update:

Done in the 88d0075

$ /oc -v 2 adm release extract --to 414 quay.io/openshift-release-dev/ocp-release:4.14.0-rc.0-x86_64 I0321 10:31:15.726235 22094 extract.go:365] Retrieved the version from image configuration in the image to extract: 4.14.0-rc.0 Extracted release payload from digest sha256:1d2cc38cbd94c532dc822ff793f46b23a93b76b400f7d92b13c1e1da042c88fe created at 2023-09-07T07:37:47Z

I cannot use the existing ImageMetadataCallback

oc/pkg/cli/image/extract/extract.go

Lines 561 to 563 in 88d0075

if o.ImageMetadataCallback != nil {

o.ImageMetadataCallback(&mapping, location.Manifest, contentDigest, imageConfig, location.ManifestListDigest())

}

because it is called too late.

openshift-ci · 2025-03-21T18:46:57Z

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`88d0075`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2025

openshift-ci bot requested review from ardaguclu and ingvagabund January 14, 2025 01:06

hongkailiu commented Jan 14, 2025

View reviewed changes

pkg/cli/admin/release/extract_tools.go Outdated Show resolved Hide resolved

hongkailiu force-pushed the OTA-1010-refactor-callback branch 5 times, most recently from ad75be6 to 38aeb1d Compare January 14, 2025 12:09

hongkailiu force-pushed the OTA-1010-refactor-callback branch 2 times, most recently from 69216c5 to 916427e Compare January 14, 2025 12:18

wking reviewed Jan 14, 2025

View reviewed changes

hongkailiu force-pushed the OTA-1010-refactor-callback branch from 916427e to 27e03eb Compare January 14, 2025 23:38

hongkailiu changed the title ~~[wip]OTA-1010: extract included manifests with net-new capabilities~~ OTA-1010: extract included manifests with net-new capabilities Jan 15, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025

hongkailiu mentioned this pull request Feb 14, 2025

OTA-1010: release extract: --include works for a minor level update #1954

Closed

openshift-ci bot requested a review from petr-muller February 14, 2025 18:34

hongkailiu force-pushed the OTA-1010-refactor-callback branch 4 times, most recently from c1909d5 to 0431ce4 Compare March 4, 2025 16:50

hongkailiu force-pushed the OTA-1010-refactor-callback branch from 0431ce4 to c1ec179 Compare March 4, 2025 22:37

hongkailiu mentioned this pull request Mar 5, 2025

[wip]OTA-1010: pull GetImplicitlyEnabledCapabilities from the cvo repo openshift/library-go#1908

Open

1 task

openshift-ci bot removed the request for review from petr-muller March 11, 2025 12:48

hongkailiu force-pushed the OTA-1010-refactor-callback branch from c1ec179 to 99cda00 Compare March 14, 2025 05:31

OTA-1010: extract included manifests with net-new capabilities

def90a6

hongkailiu force-pushed the OTA-1010-refactor-callback branch from 99cda00 to def90a6 Compare March 14, 2025 05:57

hongkailiu commented Mar 14, 2025

View reviewed changes

Log implicitly enabled caps only when existing

6bb3755

wking reviewed Mar 21, 2025

View reviewed changes

extract: figure out the target version from the pullspec

88d0075

hongkailiu force-pushed the OTA-1010-refactor-callback branch from 0be8d41 to 88d0075 Compare March 21, 2025 14:33

hongkailiu requested a review from wking March 21, 2025 14:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OTA-1010: extract included manifests with net-new capabilities #1958

OTA-1010: extract included manifests with net-new capabilities #1958

hongkailiu commented Jan 14, 2025 •

edited

Loading

openshift-ci-robot commented Jan 14, 2025 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Jan 14, 2025

openshift-ci-robot commented Jan 14, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 14, 2025 •

edited by openshift-ci bot

Loading

wking Jan 14, 2025

hongkailiu Jan 14, 2025

hongkailiu commented Jan 31, 2025

petr-muller commented Feb 14, 2025

hongkailiu commented Mar 4, 2025

hongkailiu commented Mar 4, 2025 •

edited

Loading

hongkailiu commented Mar 4, 2025

hongkailiu commented Mar 4, 2025

hongkailiu commented Mar 5, 2025

petr-muller commented Mar 11, 2025 •

edited by openshift-ci bot

Loading

hongkailiu Mar 14, 2025

hongkailiu commented Mar 17, 2025 •

edited

Loading

hongkailiu commented Mar 17, 2025

openshift-ci bot commented Mar 17, 2025

hongkailiu commented Mar 20, 2025

wking Mar 21, 2025

hongkailiu Mar 21, 2025 •

edited

Loading

hongkailiu Mar 21, 2025

openshift-ci bot commented Mar 21, 2025

	// FIXME: eventually pull in GetImplicitlyEnabledCapabilities from https://github.com/openshift/cluster-version-operator/blob/86e24d66119a73f50282b66a8d6f2e3518aa0e15/pkg/payload/payload.go#L237-L240 for cases where a minor update would implicitly enable some additional capabilities. For now, 4.13 to 4.14 will always enable MachineAPI, ImageRegistry, etc..
	currentVersion := clusterVersion.Status.Desired.Version
	matches := regexp.MustCompile(`^(\d+[.]\d+)[.].*`).FindStringSubmatch(currentVersion)
	if len(matches) < 2 {
	return config, fmt.Errorf("failed to parse major.minor version from ClusterVersion status.desired.version %q", currentVersion)
	} else if matches[1] == "4.13" {
	build := configv1.ClusterVersionCapability("Build")
	deploymentConfig := configv1.ClusterVersionCapability("DeploymentConfig")
	imageRegistry := configv1.ClusterVersionCapability("ImageRegistry")
	config.Capabilities.EnabledCapabilities = append(config.Capabilities.EnabledCapabilities, configv1.ClusterVersionCapabilityMachineAPI, build, deploymentConfig, imageRegistry)
	config.Capabilities.KnownCapabilities = append(config.Capabilities.KnownCapabilities, configv1.ClusterVersionCapabilityMachineAPI, build, deploymentConfig, imageRegistry)
	}

	if data.Capabilities.BaselineCapabilitySet == configv1.ClusterVersionCapabilitySetCurrent {
	klog.Infof("If the eventual cluster will not be the same minor version as this %s 'oc', the actual %s capability set may differ.", reportedVersion, data.Capabilities.BaselineCapabilitySet)
	}

	if o.ImageMetadataCallback != nil {
	o.ImageMetadataCallback(&mapping, location.Manifest, contentDigest, imageConfig, location.ManifestListDigest())
	}

OTA-1010: extract included manifests with net-new capabilities #1958

Are you sure you want to change the base?

OTA-1010: extract included manifests with net-new capabilities #1958

Conversation

hongkailiu commented Jan 14, 2025 • edited Loading

openshift-ci-robot commented Jan 14, 2025 • edited by openshift-ci bot Loading

openshift-ci bot commented Jan 14, 2025

openshift-ci-robot commented Jan 14, 2025 • edited by openshift-ci bot Loading

openshift-ci-robot commented Jan 14, 2025 • edited by openshift-ci bot Loading

wking Jan 14, 2025

Choose a reason for hiding this comment

hongkailiu Jan 14, 2025

Choose a reason for hiding this comment

hongkailiu commented Jan 31, 2025

petr-muller commented Feb 14, 2025

hongkailiu commented Mar 4, 2025

hongkailiu commented Mar 4, 2025 • edited Loading

hongkailiu commented Mar 4, 2025

hongkailiu commented Mar 4, 2025

hongkailiu commented Mar 5, 2025

petr-muller commented Mar 11, 2025 • edited by openshift-ci bot Loading

hongkailiu Mar 14, 2025

Choose a reason for hiding this comment

hongkailiu commented Mar 17, 2025 • edited Loading

hongkailiu commented Mar 17, 2025

openshift-ci bot commented Mar 17, 2025

hongkailiu commented Mar 20, 2025

wking Mar 21, 2025

Choose a reason for hiding this comment

hongkailiu Mar 21, 2025 • edited Loading

Choose a reason for hiding this comment

hongkailiu Mar 21, 2025

Choose a reason for hiding this comment

openshift-ci bot commented Mar 21, 2025

hongkailiu commented Jan 14, 2025 •

edited

Loading

openshift-ci-robot commented Jan 14, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 14, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 14, 2025 •

edited by openshift-ci bot

Loading

hongkailiu commented Mar 4, 2025 •

edited

Loading

petr-muller commented Mar 11, 2025 •

edited by openshift-ci bot

Loading

hongkailiu commented Mar 17, 2025 •

edited

Loading

hongkailiu Mar 21, 2025 •

edited

Loading