Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Port adm update status to UpdateStatus API #1985

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

WIP: Port adm update status to UpdateStatus API #1985

wants to merge 12 commits into from

Conversation

petr-muller
Copy link
Member

@petr-muller petr-muller commented Mar 4, 2025 •
edited
Loading

@petr-muller
github.com/openshift/api => github.com/petr-muller/api@update-status-api
b183bff 
```
go mod edit --replace github.com/openshift/api=github.com/petr-muller/api@update-status-api
go mod tidy
go mod vendor
```
@petr-muller
github.com/openshift/client-go => github.com/petr-muller/openshift-cl…
5a047d2 
…ient-go@update-status-operator

```
go mod edit --replace github.com/openshift/client-go=github.com/petr-muller/openshift-client-go@update-status-operator
go mod tidy
go mod vendor
```
@petr-muller
upgrade status: port basics to UpdateStatus
5d1ed9d
@petr-muller
upgrade status: example not-upgrading
5f99482
@petr-muller
upgrade status: store example fixtures in Go
e1b0934 
...only temporarily, it will be easier to accomodate API changes this way
@petr-muller
upgrade status: process CV & CO insights
564105d
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-muller petr-muller mentioned this pull request Mar 4, 2025
Draft
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petr-muller @openshift-merge-robot