Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCPBUGS-50992]: Filter out unreachable taints from tolerations #1990

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

midu16
Copy link

@midu16 midu16 commented Mar 11, 2025

[OCPBUGS-50992]: Filter out unreachable taints from tolerations:

  • Define a list of excluded taints (unreachableTaintKey) with effects NoExecute and NoSchedule.
  • Add tolerations for node-role.kubernetes.io/master (if applicable) and node.kubernetes.io/not-ready.
  • Filter out tolerations that match the excluded taints to prevent unintended scheduling behavior.
  • Implement a loop to iterate over tolerations and exclude ones that tolerate unreachableTaintKey.

This change ensures that workloads do not unintentionally tolerate unreachable nodes while still allowing necessary tolerations.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2025
@openshift-ci openshift-ci bot requested review from atiratree and ingvagabund March 11, 2025 19:23
Copy link
Contributor

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: midu16
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@midu16 midu16 changed the title WIP: Filter out unreachable taints from tolerations [OCPBUGS-50992]: Filter out unreachable taints from tolerations Mar 18, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2025
@midu16
Copy link
Author

midu16 commented Apr 2, 2025

/test images

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@midu16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 2849b32 link true /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn 2849b32 link true /test e2e-aws-ovn
ci/prow/verify 2849b32 link true /test verify
ci/prow/e2e-aws-ovn-serial 2849b32 link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@midu16
Copy link
Author

midu16 commented Apr 4, 2025

@ingvagabund , @atiratree i am trying to get some sense on the failed checks, but i cannot find the corelation between my proposed changed patch and the errors. What am I missing here from your point of view?

Much appreciated,
M

@ingvagabund
Copy link
Member

ingvagabund commented Apr 7, 2025

Looks like all three e2e tests are flaking (unrelated to this PR) and the verify needs to run "make update-gofmt". I think you are good here when it comes to passing the tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants