-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCPBUGS-50992]: Filter out unreachable taints from tolerations #1990
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: midu16 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test images |
@midu16: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@ingvagabund , @atiratree i am trying to get some sense on the failed checks, but i cannot find the corelation between my proposed changed patch and the errors. What am I missing here from your point of view? Much appreciated, |
Looks like all three e2e tests are flaking (unrelated to this PR) and the verify needs to run "make update-gofmt". I think you are good here when it comes to passing the tests :) |
[OCPBUGS-50992]: Filter out unreachable taints from tolerations:
unreachableTaintKey
) with effectsNoExecute
andNoSchedule
.node-role.kubernetes.io/master
(if applicable) andnode.kubernetes.io/not-ready
.unreachableTaintKey
.This change ensures that workloads do not unintentionally tolerate unreachable nodes while still allowing necessary tolerations.