Skip to content

CNV-63574: Add details about the spec.domain.cpu.numa attribute and UI badge #100939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

CNV-63574: Add details about the spec.domain.cpu.numa attribute and UI badge #100939

merged 1 commit into from
Oct 28, 2025

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Oct 22, 2025 •
edited
Loading

@abrennan89 abrennan89 added this to the Continuous Release milestone Oct 22, 2025
@abrennan89 abrennan89 added the CNV Label for all CNV PRs label Oct 22, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2025 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references CNV-63574 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/CNV-63574

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Needs to be rebased once #99140 is merged - currently cherrypicking this PR to allow previews and not duplicate the work for the assembly, topicmap etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 22, 2025 •
edited
Loading

🤖 Mon Oct 27 16:52:55 - Prow CI generated the docs preview:

https://100939--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-NUMA-topology.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2025 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references CNV-63574 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/CNV-63574

Link to docs preview:
https://100939--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-numa-topology#virt-numa-check-config_virt-NUMA-topology

QE review:

  • QE has approved this change.

Additional information:
Needs to be rebased once #99140 is merged - currently cherrypicking this PR to allow previews and not duplicate the work for the assembly, topicmap etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 24, 2025
jherrman
jherrman reviewed Oct 24, 2025
View reviewed changes
Copy link
Contributor

@jherrman jherrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments and suggestions for your consideration by way of peer review.

@abrennan89 abrennan89 added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 27, 2025 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references CNV-63574 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/CNV-63574

Link to docs preview:
https://100939--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-numa-topology#virt-numa-check-config_virt-NUMA-topology

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 changed the title [WIP] CNV-63574: Add details about the spec.domain.cpu.numa attribute and UI badge CNV-63574: Add details about the spec.domain.cpu.numa attribute and UI badge Oct 27, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2025

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lkladnit
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@lkladnit lkladnit removed their assignment Oct 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references CNV-63574 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/CNV-63574

Link to docs preview:
https://100939--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-numa-topology#virt-numa-check-config_virt-NUMA-topology

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 merged commit f33d71a into openshift:main Oct 28, 2025
2 checks passed
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.20

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.21

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #101156

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 28, 2025
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #101157

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jherrman jherrman jherrman left review comments

@lkladnit lkladnit lkladnit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.20 branch/enterprise-4.21 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@abrennan89 @openshift-ci-robot @ocpdocs-previewbot @lkladnit @openshift-cherrypick-robot @jherrman