-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-16225 [NETOBSERV] New Network Observability Operator alerts content #99499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
46c11ff
to
2e716ef
Compare
🤖 Thu Oct 16 17:49:16 - Prow CI generated the docs preview: |
d1992bb
to
3c61dec
Compare
observability/network_observability/network-observability-alerts.adoc
Outdated
Show resolved
Hide resolved
modules/network-observability-configuring-predefined-alerts.adoc
Outdated
Show resolved
Hide resolved
modules/network-observability-configuring-predefined-alerts.adoc
Outdated
Show resolved
Hide resolved
observability/network_observability/network-observability-alerts.adoc
Outdated
Show resolved
Hide resolved
@gwynnemonahan I've updated the upstream a little bit: netobserv/network-observability-operator#2070 Changes are:
|
observability/network_observability/network-observability-alerts.adoc
Outdated
Show resolved
Hide resolved
9a97304
to
46ac75c
Compare
observability/network_observability/network-observability-alerts.adoc
Outdated
Show resolved
Hide resolved
9b2476f
to
8a12249
Compare
Hey @jotak , I've made updates based on your changes. Please take a look. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gwynnemonahan , great doc! (I really like how you structured the "about promQL" part 👍 )
Just a few small comments
modules/network-observability-alerts-about-promql-expression.adoc
Outdated
Show resolved
Hide resolved
modules/network-observability-alerts-about-promql-expression.adoc
Outdated
Show resolved
Hide resolved
modules/network-observability-alerts-about-promql-expression.adoc
Outdated
Show resolved
Hide resolved
d4572ec
to
964ef47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
/label merge-review-needed |
/remove-label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label qe-approved
/label merge-review-needed |
/remove-label merge-review-needed There are some discrepancies between what is showing in GitHub and what is showing in VSCode, and I want to try and address those, based on the Rel Notes PR. Removing label for merge review. |
c8dd7a5
to
bec021a
Compare
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM. Let me know after you've addressed comments if you need a merge.
modules/network-observability-configuring-predefined-alerts.adoc
Outdated
Show resolved
Hide resolved
observability/network_observability/network-observability-alerts.adoc
Outdated
Show resolved
Hide resolved
e510a28
to
8bdce5f
Compare
f19e39c
to
3ac226d
Compare
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
OSDOCS-16225 [NETOBSERV] New Network Observability Operator alerts content
TECHNOLOGY PREVIEW FEATURE
Version(s):
Merge to only the
no-1.10
branch - no cherrypicks are required.I will open one PR against main to incorporate all of the <no-.10> content just before its GA.
Note to self for integration: applies to OCP 4.12, 4.14+
Issue:
https://issues.redhat.com/browse/OSDOCS-16225
Link to docs preview:
QE review:
Additional information: