Skip to content

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Sep 22, 2025

OSDOCS-16225 [NETOBSERV] New Network Observability Operator alerts content

TECHNOLOGY PREVIEW FEATURE

Version(s):
Merge to only the no-1.10 branch - no cherrypicks are required.
I will open one PR against main to incorporate all of the <no-.10> content just before its GA.

Note to self for integration: applies to OCP 4.12, 4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-16225

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 22, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 22, 2025

@jotak
Copy link

jotak commented Oct 3, 2025

@gwynnemonahan I've updated the upstream a little bit: netobserv/network-observability-operator#2070

Preview: https://github.com/netobserv/network-observability-operator/blob/f3d67c2714d7de8efb12e8a88a6067cb04f15358/docs/Alerts.md

Changes are:

  • Like mentioned here, remove the threshold and grouping details from the list of default alerts
  • More importantly I've added a section that was missing, on metadata, when user want to create their own alerts
  • In the promql examples, I've replaced all occurrences of netobserv_namespace_ingress_bytes_total with netobserv_workload_ingress_bytes_total. The reason is that we changed the latter to be the new default, so unless they have a specific config, users will likely have that one available instead of the other.

@gwynnemonahan
Copy link
Contributor Author

@gwynnemonahan I've updated the upstream a little bit: netobserv/network-observability-operator#2070

Preview: https://github.com/netobserv/network-observability-operator/blob/f3d67c2714d7de8efb12e8a88a6067cb04f15358/docs/Alerts.md

Changes are:

  • Like mentioned here, remove the threshold and grouping details from the list of default alerts
  • More importantly I've added a section that was missing, on metadata, when user want to create their own alerts
  • In the promql examples, I've replaced all occurrences of netobserv_namespace_ingress_bytes_total with netobserv_workload_ingress_bytes_total. The reason is that we changed the latter to be the new default, so unless they have a specific config, users will likely have that one available instead of the other.

Hey @jotak ,

I've made updates based on your changes. Please take a look. Thanks!

Copy link

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gwynnemonahan , great doc! (I really like how you structured the "about promQL" part 👍 )
Just a few small comments

Copy link

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 15, 2025
@gwynnemonahan
Copy link
Contributor Author

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 15, 2025
Copy link

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 15, 2025
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 15, 2025
@gwynnemonahan
Copy link
Contributor Author

/remove-label merge-review-needed

There are some discrepancies between what is showing in GitHub and what is showing in VSCode, and I want to try and address those, based on the Rel Notes PR. Removing label for merge review.

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 15, 2025
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 16, 2025
@lpettyjo lpettyjo added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 16, 2025
@lpettyjo lpettyjo self-requested a review October 16, 2025 14:33
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM. Let me know after you've addressed comments if you need a merge.

@lpettyjo lpettyjo added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Oct 16, 2025
Copy link

openshift-ci bot commented Oct 16, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lpettyjo lpettyjo merged commit 1aca99d into openshift:no-1.10 Oct 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-merge qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants