-
Notifications
You must be signed in to change notification settings - Fork 4.8k
SPLAT-2337: Added OTE binary for ccm-aws #30235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPLAT-2337: Added OTE binary for ccm-aws #30235
Conversation
|
@mtulio: This pull request references SPLAT-2337 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
2d904d4 to
eaa43cf
Compare
|
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117 |
1 similar comment
|
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117 |
|
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117
CI Infra issue while installing cluster / creating IAM roles (I wonder if we need a backoff/retry improvement in that part) - testing again: |
|
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117 |
1 similar comment
|
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117 |
|
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117 |
|
Converting to draft, investigating issues on |
|
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117 |
I can build the image in ccm repo using the PR openshift/cloud-provider-aws#117 , let me try again. |
|
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117 |
1 similar comment
|
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117 |
|
The latest testwith ran correctly, with 5/7 tests failing. I just updated the CCM/OTE PR to address the issue. re-trying ^ (my last comment) |
|
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117 |
|
something went wrong in the last rebase, I will remove the unrelated OTE commits soon in my next cycle. |
|
Successful execution =) I just converted the ccm-aws repo to ready for review with final changes. Triggering with latest version to ensure readiness after updating vedor: |
|
Job Failure Risk Analysis for sha: 3cf42fd
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 3cf42fd
|
|
/hold Revision 3cf42fd was retested 3 times: holding |
|
I will work on #30476 to increase verbosity on OTE binary to investigate issues affecting only the job e2e-metal-ipi-ovn-ipv6. |
|
/testwith openshift/origin/main/e2e-metal-ipi-ovn-ipv6 #30476 openshift/cloud-provider-aws#122 |
|
/testwith openshift/origin/main/e2e-aws-ovn #30476 openshift/cloud-provider-aws#122 |
Fix 'list images' to satisfy the contract of OTE while listing available images in workflow e2e-metal-ipi-ovn-ipv6.[1][2] Main PR introducing the extraction: openshift/origin#30235 [1] Failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30235/pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6/1988577993307459584#1:build-log.txt%3A174-176 [2] validated by: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-origin-30235-openshift-origin-30476-openshift-cloud-provider-aws-122-e2e-metal-ipi-ovn-ipv6/1988964899904032768
Fix 'list images' to satisfy the contract of OTE while listing available images in workflow e2e-metal-ipi-ovn-ipv6.[1][2] OTE PR extraction: openshift/origin#30235 Jira: https://issues.redhat.com/browse/SPLAT-2337 [1] Failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30235/pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6/1988577993307459584#1:build-log.txt%3A174-176 [2] validated by: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-origin-30235-openshift-origin-30476-openshift-cloud-provider-aws-122-e2e-metal-ipi-ovn-ipv6/1988964899904032768
this one is passing. Awaiting openshift/cloud-provider-aws#122 to be fixed before asking for review here |
Fix 'list images' to satisfy the contract of OTE while listing available images in workflow e2e-metal-ipi-ovn-ipv6.[1][2] OTE PR extraction: openshift/origin#30235 Jira: https://issues.redhat.com/browse/SPLAT-2337 [1] Failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30235/pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6/1988577993307459584#1:build-log.txt%3A174-176 [2] validated by: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-origin-30235-openshift-origin-30476-openshift-cloud-provider-aws-122-e2e-metal-ipi-ovn-ipv6/1988964899904032768
|
Job Failure Risk Analysis for sha: 3cf42fd
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 3cf42fd
|
|
PR openshift/cloud-provider-aws#122 merged, re-trying> /test e2e-metal-ipi-ovn-ipv6 |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 3cf42fd
|
Per tests passing: /hold cancel |
|
Scheduling required tests: |
|
@mtulio: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 3cf42fd
New tests seen in this PR at sha: 3cf42fd
|
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 3cf42fd
|
1 similar comment
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 3cf42fd
|
24a0dee
into
openshift:main
Enalbe presubmit jobs on origin, CCCMO, and cloud-provider-aws to validate conformance jobs on techpreview using hypershift, ensuring upstream CCM-AWS e2e tests recently introduced is executed correctly in hypershift workload clusters. Ref openshift/origin#30235
Enalbe presubmit jobs on origin, CCCMO, and cloud-provider-aws to validate conformance jobs on techpreview using hypershift, ensuring upstream CCM-AWS e2e tests recently introduced is executed correctly in hypershift workload clusters. Ref openshift/origin#30235
Added binary to the OTE of a project cloud-provider-aws.
Acceptance criteria
Changes that must be tested with the OTE:
The following tests must be successful executed to validate the feature with OTE:
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#121 openshift/cluster-cloud-controller-manager-operator#391/testwith openshift/origin/main/e2e-gcp-ovn openshift/cloud-provider-aws#121 openshift/cluster-cloud-controller-manager-operator#391/testwith openshift/origin/main/e2e-vsphere-ovn openshift/cloud-provider-aws#121 openshift/cluster-cloud-controller-manager-operator#391To validate the passing scenario, we are using those conditionals:
/usr/bin/aws-cloud-controller-manager-tests-ext.gzmust be extracted by openshift-tests in the stepopenshift-e2e-test(query string:msg="Extracted /usr/bin/aws-cloud-controller-manager-tests-ext.gz)ms" binary=aws-cloud-controller-manager-tests-ext)msg="Listed 7 tests in 57.89931ms" binary=aws-cloud-controller-manager-tests-extmsg="Listed 0 tests in 52.698354ms" binary=aws-cloud-controller-manager-tests-ext[cloud-provider-aws-e2] *on AWS, or just run regular e2e without any CCM tests on other providers.[cloud-provider-aws-e2e] nodestotal of 2 tests. (query:passed: * "[cloud-provider-aws-e2e] nodes)`[cloud-provider-aws-e2e] loadbalancertotal of 5 tests. (query:passed: * "[cloud-provider-aws-e2e] loadbalancer)`)Test results:
Related to: