Skip to content

Add e2e tests to validate DRA APIs #30462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add e2e tests to validate DRA APIs #30462

wants to merge 1 commit into from

Conversation

@sairameshv
Copy link
Member

@sairameshv sairameshv commented Nov 5, 2025 •
edited
Loading

  • DynamicResourceAllocation feature has been graduated to GA
  • We need a few e2e tests defined downstream for this featuregate to be enabled to the Default cluster type
  • Added a test to validate the downstream specific code that depends on the DynamicResourceAllocation featuregate

Helps in promoting openshift/api#2498

Tests generated by Claude

cc: @tkashem @haircommander

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial November 5, 2025 15:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sairameshv
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sairameshv sairameshv changed the title Add e2e tests to validate DRA Add e2e tests to validate DRA APIs Nov 5, 2025
@openshift-trt
Copy link

openshift-trt bot commented Nov 6, 2025

Job Failure Risk Analysis for sha: c97ac81

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-gcp-csi High
Undiagnosed panic detected in pod
This test has passed 99.93% of 2978 runs on release 4.21 [Overall] in the last week.

Open Bugs
Undiagnosed Panic: openshift-cloud-controller-manager_azure-cloud-node-manager

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: c97ac81

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] server supports sending resources in Table format" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] should NOT be requested by client-go's List method when WatchListClient is enabled" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] should NOT be requested by metadata client's List method when WatchListClient is enabled" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-node] NoExecuteTaintManager Multiple Pods [Serial] only evicts pods without tolerations from tainted nodes" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-node] NoExecuteTaintManager Single Pod [Serial] pods evicted from tainted nodes have pod disruption condition" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-node] Pod Level Resources [Serial] [Feature:PodLevelResources] [FeatureGate:PodLevelResources] [Beta] Burstable QoS pod, 1 container with resources" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-scheduling] Multi-AZ Clusters should spread the pods of a service across zones [Serial]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-scheduling] SchedulerPredicates [Serial] PodTopologySpread Filtering validates 4 pods with MaxSkew=1 are evenly distributed into 2 nodes" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-storage] CSI Mock selinux on mount metrics and SELinuxWarningController SELinuxMount metrics [LinuxOnly] [Feature:SELinux] [Serial] warning is bumped on two Pods with a different context on RWO volume [FeatureGate:SELinuxMountReadWriteOncePod] [Beta] [FeatureGate:SELinuxChangePolicy] [Beta] [Feature:SELinuxMountReadWriteOncePodOnly]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-storage] CSI Mock selinux on mount metrics and SELinuxWarningController SELinuxMount metrics [LinuxOnly] [Feature:SELinux] [Serial] warning is bumped on two Pods with different policies on RWO volume [FeatureGate:SELinuxMountReadWriteOncePod] [Beta] [FeatureGate:SELinuxChangePolicy] [Beta] [Feature:SELinuxMountReadWriteOncePodOnly]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-storage] [Serial] Volume metrics Ephemeral should create volume metrics with the correct BlockMode PVC ref" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-storage] [Serial] Volume metrics PVC should create volume metrics in Volume Manager" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-storage] [Serial] Volume metrics PVC should create volume metrics with the correct FilesystemMode PVC ref" is a new test, and was only seen in one job.

New tests seen in this PR at sha: c97ac81

  • "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] server supports sending resources in Table format" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] should NOT be requested by client-go's List method when WatchListClient is enabled" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] should NOT be requested by metadata client's List method when WatchListClient is enabled" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-api-machinery] CBOR [Feature:CBOR] clients remain compatible with the 1.17 sample-apiserver [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-api-machinery] Namespaces [Serial] should always delete fast (ALL of 100 namespaces in 150 seconds) [Feature:ComprehensiveNamespaceDraining]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-apps] Daemon set [Serial] should not update pod when spec was updated and update strategy is OnDelete" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-apps] Daemon set [Serial] should surge pods onto nodes when spec was updated and update strategy is RollingUpdate" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-apps] DisruptionController evictions: maxUnavailable deny evictions, integer => should not allow an eviction [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-apps] Job should run a job to completion with CPU requests [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-network] IngressClass [Feature:Ingress] should choose the one with the later CreationTimestamp, if equal the one with the lower name when two ingressClasses are marked as default [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-network] IngressClass [Feature:Ingress] should set default value on new IngressClass [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-network] Networking should allow creating a Pod with an SCTP HostPort [LinuxOnly] [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-network] Services should allow creating a basic SCTP service with pod and endpoints [LinuxOnly] [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-node] NoExecuteTaintManager Multiple Pods [Serial] only evicts pods without tolerations from tainted nodes" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node] NoExecuteTaintManager Single Pod [Serial] pods evicted from tainted nodes have pod disruption condition" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node] Pod Level Resources [Serial] [Feature:PodLevelResources] [FeatureGate:PodLevelResources] [Beta] Burstable QoS pod, 1 container with resources" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-scheduling] Multi-AZ Clusters should spread the pods of a service across zones [Serial]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-scheduling] SchedulerPredicates [Serial] PodTopologySpread Filtering validates 4 pods with MaxSkew=1 are evenly distributed into 2 nodes" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-scheduling] SchedulerPredicates [Serial] validates local ephemeral storage resource limits of pods that are allowed to run" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-scheduling] SchedulerPredicates [Serial] validates that taints-tolerations is respected if matching" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • (...showing 20 of 31 tests)

tkashem
tkashem reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

@tkashem tkashem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should verify beta and alpha DRA APIs are disabled adds value for OpenShift, other tests are already covered by the upstream tests

sairameshv
sairameshv commented Nov 10, 2025
View reviewed changes
Copy link
Member Author

@sairameshv sairameshv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the review comments, Could you take a re-look @tkashem ?

@sairameshv
Add e2e tests to validate the disabled alpha, beta DRA APIs
50cc699 
- DynamicResourceAllocation has been graduated to GA in k8s 1.34
- Added tests to verify the alpha, beta APIs of DRA are disabled in OCP

Signed-off-by: Sai Ramesh Vanka <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@sairameshv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 50cc699 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

1 more reviewer

@tkashem tkashem tkashem left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sairameshv @tkashem