-
Notifications
You must be signed in to change notification settings - Fork 4.8k
CORENET-6491: Delete test namesapces for UDN testing #30500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pipeline controller notification For optional jobs, comment |
|
@qiowang721: This pull request references CORENET-6491 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
/verified by @qiowang721 |
|
@qiowang721: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @stbenjam could you please help review this PR? Thanks a lot. |
|
cc @rioliu-rh who worked on migrating this util. Thanks |
|
Does func |
Hi @rioliu-rh , should not need to fix that one, seems that func is used for upgrade testing, so the namespaces need to be removed by user after PstChkUpgrade testing done. |
ok, thanks |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiowang721, rioliu-rh, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
/test e2e-aws-ovn-serial-1of2 |
4b8ee73
into
openshift:main
The namesapces created for UDN testing will not be removed automatically now, call c.kubeFramework.AddNamespacesToDelete to remove the namespaces at the end of testing.
Run case 74921 locally to verify the fixing:
https://privatebin.corp.redhat.com/?ceee793a25da3fb7#2DjbofyE5CPbJJLyy3xRdWpiPTFToXJHFsrRgNaUCFsU