[release-4.20] CNTRLPLANE-1544: tests: authorization/rbac: Add restricted-v3 scc #30502
Conversation
We need to include restricted-v3 scc in the list of rules for authenticated users, but iff the associated ClusterRoleBinding exists. This is a temporary and conditional fix to make tests passing for openshift/cluster-kube-apiserver-operator#1944 A subsequent PR is gonna be opened once the PR above is merged.
|
Pipeline controller notification For optional jobs, comment |
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CNTRLPLANE-1544 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| rbacv1helpers.NewRule("list", "watch").Groups(projectGroup, legacyProjectGroup).Resources("projects").RuleOrDie(), | ||
|
|
||
| rbacv1helpers.NewRule("use").Groups(security.GroupName).Resources("securitycontextconstraints").Names("restricted-v2").RuleOrDie(), | ||
| // TODO: Uncomment this once https://github.com/openshift/cluster-kube-apiserver-operator/pull/1944 is merged. |
There was a problem hiding this comment.
note: this TODO is for openshift/cluster-kube-apiserver-operator#1950 not 1944. I am in favor of using the bot (and thus have this comment slightly wrong) but can open my own if maintainers don't like it
|
/payload-with-prs 4.20 ci informing openshift/cluster-kube-apiserver-operator#1950 |
|
@haircommander: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-with-prs 4.20 ci informing openshift/cluster-kube-apiserver-operator#1950 |
|
@haircommander: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-with-prs 4.20 ci informing openshift/cluster-kube-apiserver-operator#1950 |
|
@haircommander: trigger 1 job(s) of type informing for the ci release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/74945270-c56d-11f0-8a03-ef1cbd437d77-0 |
|
/retest |
|
Scheduling required tests: |
|
payload passed |
openshift-ci-robot
added
the
jira/valid-reference
|
@haircommander: This pull request references CNTRLPLANE-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.21" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
This is an automated cherry-pick of #30384
/assign haircommander