Skip to content

sandboxed-containers: fix the pullspecs of the operator #66424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

sandboxed-containers: fix the pullspecs of the operator #66424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...penshift/sandboxed-containers-operator/openshift-sandboxed-containers-operator-devel.yaml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR but now that OCP 4.19 is GA maybe we can bump the base image from "4.18" to "4.19" ?

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ operator:
- as: openshift-sandboxed-containers-operator-bundle
dockerfile_path: bundle.Dockerfile
substitutions:
- pullspec: quay.io/openshift_sandboxed_containers/openshift-sandboxed-containers-operator:.*
- pullspec: registry.redhat.io/openshift-sandboxed-containers/osc-rhel9-operator@sha256:.*
with: pipeline:openshift-sandboxed-containers-operator
releases:
initial:
Expand Down
2 changes: 1 addition & 1 deletion ...ft/sandboxed-containers-operator/openshift-sandboxed-containers-operator-release-1.8.yaml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer use https://github.com/openshift/sandboxed-containers-operator/tree/release-1.8, do we ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering same.
No I think we don't - this branch has not seen updates in a while.
Should I delete the related jobs as part of the same PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think it is acceptable if you remove all the 1.8 related files in this PR but in a separate commit.

We'll create something for 1.10 when the release branch is created in the operator repo.

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ operator:
- as: openshift-sandboxed-containers-operator-bundle
dockerfile_path: bundle.Dockerfile
substitutions:
- pullspec: quay.io/openshift_sandboxed_containers/openshift-sandboxed-containers-operator:.*
- pullspec: registry.redhat.io/openshift-sandboxed-containers/osc-rhel9-operator@sha256:.*
with: pipeline:openshift-sandboxed-containers-operator
releases:
initial:
Expand Down