-
Notifications
You must be signed in to change notification settings - Fork 59
konflux: Make description of entries more readable #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
35f69ee
to
3030f41
Compare
/retest |
Some of the entries were beginning with `- default`. This is confusing during code review [1], where you tend to read that as belonging to the previous item instead of the current one. Move `default` after description, which puts description right after `-` to avoid that problem. [1]: openshift#678 (comment) Signed-off-by: Christophe de Dinechin <[email protected]>
3030f41
to
054595b
Compare
/retest |
I agree with the change, but just want to reiterate a warning I did in another place: these files are generated by Konflux, and updated automatically by it. It may or may not restore the alphabetical ordering in a future update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better. I'm not sure if the same will hold true with Konflux, though. Unfortunately, this was previously overridden by some automation tools, and it was hard to maintain the correct order. Hopefully we won’t run into that again here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for not starting with the name?
Didn't say this answer. And this answer my comment above :) |
/retest |
@c3d: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Caution There are some errors in your PipelineRun template.
|
Some of the entries were beginning with
- default
. This is confusing during code review 1, where you tend to read that as belonging to the previous item instead of the current one. Movedefault
after description, which puts description right after-
to avoid that problem.